5 Commits

Author	SHA1	Message	Date
Martin-Molinero	27de93f78f	Market orders wait for fresh data instead of filling on stale prices (#9535) ... * Market orders wait for fresh data instead of filling on stale prices A market order would previously fill immediately on the most recent available data even when that data was older than StalePriceTimeSpan (default one hour), only attaching a warning. This is unrealistic for a coarse resolution asset (hour/daily) where the latest bar is the stale previous close when the order is placed mid-bar or via an intraday scheduled event. The default fill models (FillModel, EquityFillModel, FutureFillModel) now wait for fresh data instead of filling on a stale price, but only for hour and daily resolutions; the order fills when the next bar closes. For minute/second/tick subscriptions the previous behavior is kept (fill on the stale price with a warning), since stale data there is a genuine gap rather than a bar still forming. Adds HourResolutionMarketOrderStalePriceRegressionAlgorithm, updates the FillOutsideHours daily expectation, and regenerates statistics for the hour/daily algorithms whose fills change. FutureOptionDaily buys and liquidates a day apart now (a same-day buy + liquidate cannot fill on daily data once stale fills are disabled). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Normalize and correct StalePriceTimeSpan XML docs The interface and class docs now match and reflect the actual behavior: the wait-for-fresh-data only applies to hour/daily resolutions, while minute/second/tick subscriptions still fill on stale data with a warning. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Fill resting market orders at the bar open instead of the close A hour/daily market order that was resting before the current bar opened (it predates the bar - placed after the previous close or while waiting for fresh data) now fills at the bar open, the price when trading resumed (like a MarketOnOpen), instead of the bar close. Orders placed during the bar still fill at the current/close price, so intraday mid-bar fills are unchanged. Equity fills are unchanged (resting equity orders are already converted to MarketOnOpen by QCAlgorithm.MarketOrder). Adds the shared FillModel.GetMarketFillPrice helper used by the base FillModel and FutureFillModel, a unit test, and regenerates statistics for the affected daily/hour futures, index and crypto regression algorithms (order counts unchanged, only fill prices). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Add regression algorithm asserting resting market orders fill at the bar open RestingMarketOrderFillsAtBarOpenRegressionAlgorithm buys a daily future on the bar that delivers it (fills at that bar's close) and submits a liquidation while the market is closed (overnight pulse, no fresh bar). The liquidation rests and fills on a later bar at the bar open, not its close - asserting the new GetMarketFillPrice behavior. The in-bar buy is asserted to fill at the close, for contrast. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Carry the bar start time on Prices instead of re-reading the cache Add Prices.Time (the bar start, mirroring BaseData.Time/EndTime), populated from the source bar/tick in every GetPrices path. GetMarketFillPrice now uses prices.Time directly instead of a second asset.Cache.GetData() lookup. Behavior is unchanged (prices.Time equals the previously read cache time). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Add regression algorithm asserting in-session hour orders fill at the latest close HourMarketOrderFillsAtBarCloseRegressionAlgorithm submits an hour resolution market order mid-bar (via an intraday scheduled event) while the market is open, using the default one hour StalePriceTimeSpan. It asserts the order fills immediately at the latest available bar's close - not waiting and not at the bar open - since the latest bar is within the stale window. Guards the resting-order open-fill behavior against affecting ordinary in-session fills. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Regenerate custom fill model algorithm statistics for the open-fill change CustomModelsAlgorithm and CustomPartialFillModelAlgorithm subscribe SPY at hour resolution and their custom fill models delegate to base.MarketFill, so resting orders now fill at the bar open. Regenerate their statistics (C#/Python) and the inline expected statistics of the PEP8StyleCustomModelsWork test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-18 11:59:19 -03:00
Jhonathan Abreu	c81f5d7d1a	Seed securities by default (#9045) ... * Add SeedInitialPrices algorithm setting This is true by default and indicates that the engine will seed initial prices right after the security is added or selected * Update regression algorithms * Update regression algorithms * Update regression algorithms * Refactor default securities seeding * Minor fix * Minro fixes * Cleanup * Updated and add regression algorithms * Address peer review * Centralize logic to get last known data for multiple securities * Some cleanup * Minor build fix * Minor fixes * More logic centralization * Some more cleanup * Cleanup * Update regression algorithms and minor fixes * Update regression algorithms * Minor fix * More minor fixes * Update regression algorithms * Cleanup * Minor test fix * Address peer review * Minor fix and performance improvement * Fix to seed open interest data * Minor test fixes * Address peer review * Minor change * Minor revert * Minor fixes and improvements * Disable initial seeding by default * Minor fixes * Cleanup * Cleanup * Minor fix	2025-11-18 13:05:56 -04:00
JosueNina	7008d17714	Add MaxDrawdownRecovery metric (#8865) ... * Implement a prototype of the maximum recovery time function. * Add unit test skeletons. * Add failing test * Issue #4581: Implement MaxDrawdownRecoveryTime. * Issue 4581: Add DTO for Drawdown Percentage, Drawdown Enddate, and High Value * Issue 4581: Fix bgu for when lDrawdowns list is empty. * Issue 4581: Change names of tests. Change name of file. * Issue 4581: Make adjustements to flow of adding drawdowns to lDrawdowns. * Issue 4581: Add multiple unit tests. * Issue #4581: Change name of unit test * Issue #4581: Add to PerformanceMetrics * Issue #4581: Add Maximum Drawdown Recovery to PortolioStatistics class. * Issue #4581: Add to portolfio statistics class. * Issue #4581: Add to statistics builder. * Issue #4581: Add report key. * Case #4581: Convert to decimal. * Issue #4581: Correct comment. * Issue #4581: Correct performance metrics view model string. * Case #4581: Correct statistics builder view model string..again. * Issue #4581: Placed DradownDradownDateHighValueDTO at the end of the file for simpler diff. * Issue #4581: Add 2 new tests. * Issue #4581: Change algorithm so that when multiple maximum drawdowns occur, the longest of all recoveries is reported. * Issue #4581: Add unit test. * Issue #4581: Remove reportkey. Change dto name. * Issue #4581: Change summary. * Issue #4581: Change comment. * Add max drawdown recovery calculation with unit tests * Update regression algorithms with the new metric * Solve review comments * Update regression algorithms * Add TryGet to safely get the key: MaximumDrawdownRecovery * Ignore MaximumDrawdownRecovery metric in OptimizationBacktest Json * Revert changes in Messaging * Update regression algorithms * Add test case: TakesLongestRecoveryAmongMultipleDrawdowns * Use integer days for MaximumDrawdownRecovery * Add MaximumDrawdownRecoveryReportElement * Use more explicit names * Rename files and variables for consistency * Update regression algorithms --------- Co-authored-by: Alain Schaerer <aschaerer@pcatg.com>	2025-07-17 16:32:23 -03:00
Ricardo Andrés Marino Rojas	980cdeaa75	Remove fill warnings from order tags (#8668) ... * Remove warnings from tags and tests * Fix bugs * fix bugs * Revert wrong updates in some stats * Fix bugs	2025-04-03 17:49:21 -03:00
JosueNina	3b559a5f3f	Fix bug in beta value computation (#8466) ... * Fix bug in beta calculation - Beta is fill-forwarded - A correct pair considered when they have different symbols and the same date - Processing occurs when there are at least period+1 correct pairs * Address review comments * Add time zone handling and resolution-based truncation * Fix regression test for Beta indicator * Handle resolution for beta indicator - Remove effectiveResolution and Beta constructor parameter for resolution. - Streamlined resolution handling logic for Beta indicator. - Fixed issues with regression test for Beta. * Fix issue with period and WarmUpPeriod * Update unit tests for Alpha indicator * Fixing minor issues * Add a variable to track if the previous symbol is the target * Add regression test for Beta calculation between BTCUSD and SPY * Add an extra period if the TZ are different	2024-12-20 18:22:04 -03:00