Files
Zeyi (Rice) Fan 244ded1ed9 chore(deps): move development tooling to internal groups (#4626)
## Related issue

N/A

## Summary

The published `dev` extra mixed repository workflows with installable Omnigent capabilities. Move contributor-only dependencies to PEP 735 groups so package extras describe product functionality and CI installs only the workflow dependencies it executes.

- Replace the `dev` extra with local-only `lint`, `test`, and aggregate `dev` groups; configure no default groups so plain `uv sync` matches the published base package.
- Remove the retired mypy dependency/configuration, `types-PyYAML`, the orphaned `pathspec` declaration, and the duplicate `filelock` declaration.
- Migrate workflows, actions, contributor commands, tests, and development skills from `--extra dev` to the smallest required group, or no group for application/benchmark jobs.
- Compose Pyrefly's lint environment from the `lint` group plus the existing `hindsight`, `nimble`, `s3`, and `tracing` capability extras. Remove the OpenTelemetry missing-import configuration and Nimble's inline missing-import suppression so real package types remain checked.
- Update OpenShell, e2e, browser-test, Slack, and implementation-plan commands to compose capability extras with repository groups explicitly. Document why read-only/tools-less agent workflows intentionally keep runtime-only environments.
- Avoid `--all-extras`: it resolves but selects 240 product packages, including unrelated large/native integrations. Keep capability ownership explicit instead.

ELI5: product features remain extras users can install; lint and test toolboxes become private repository groups that never appear in the wheel.

```text
published wheel: base + capability extras
repository:      lint group | test group | dev = lint + test
CI lint:         lint + explicitly type-checked capability extras
```

## Test Plan

- `uv lock && just normalize-locks`
- Built the wheel and verified its metadata contains no `dev` extra or lint/test dependencies.
- Verified a fresh base environment imports Omnigent, excludes lint/test/pathspec packages, and imports each release benchmark script.
- `uv run --isolated --frozen --group lint --extra hindsight --extra nimble --extra s3 --extra tracing pre-commit run pyrefly --all-files`
- `uv run --isolated --frozen --group lint python scripts/gen_routing_pb2.py --check`
- Verified isolated `test` and aggregate `dev` group membership independently.
- `uv run --isolated --frozen --group test pytest tests/tools/builtins/test_hindsight.py tests/tools/builtins/test_nimble_research.py tests/stores/test_s3_artifact_store.py tests/db/test_d1_fts_dialect.py -q` (172 passed)
- `uv run --isolated --frozen --group test --extra tracing pytest tests/runtime/test_telemetry.py tests/inner/test_tracing_genai_semconv.py -q` (69 passed)
- `uv run --isolated --frozen --extra openshell --group test pytest tests/onboarding/sandboxes/test_openshell.py tests/server/test_managed_hosts.py -q` (259 passed)
- Verified load-test modules import with only `loadtest` and `agents-sdk` extras.
- Ran the exact locked lint sync against PyPI and Pyrefly passed.
- Rebased onto current `origin/main`; migrated the newly added compatibility-smoke test actions and host benchmark workflow.
- Surveyed all tracked uv install/run commands and removed every remaining published-`dev`/implicit-tooling command. Verified the documented e2e and Slack environments and collected the Kimi/live-DDG tests in fresh group-selected environments.
- `uv run --frozen pre-commit run --all-files`

## Demo

N/A — dependency metadata and CI configuration only.

## Type of change

- [ ] Bug fix
- [ ] Feature
- [ ] UI / frontend change
- [x] Refactor / chore
- [ ] Docs
- [ ] Test / CI
- [ ] Breaking change

## Test coverage

- [ ] Unit tests added / updated
- [ ] Integration tests added / updated
- [ ] E2E tests added / updated
- [x] Manual verification completed
- [x] Existing tests cover this change
- [ ] Not applicable

## Coverage notes

Fresh isolated environments validated the base, lint, test, aggregate dev, tracing-test, and load-test dependency boundaries. Focused tests prove retained optional clients are genuine test runtimes, while wheel inspection proves repository groups are not published.

Signed-off-by: Zeyi (Rice) Fan <zeyi.f@databricks.com>
2026-08-13 18:00:38 -07:00

16 KiB
Raw Permalink Blame History

Contributing to Omnigent

Thanks for your interest in improving Omnigent. Issues and pull requests are welcome. For larger changes, open an issue first so we can discuss the approach.

Please don't include secrets, internal URLs, customer data, or private configuration in issues, tests, examples, or logs.

Issue prioritization

We rank open community issues so maintainers see the most important work first. The ranking is a triage aid, not a delivery promise or roadmap commitment.

An LLM reads the issue title, body, and labels and classifies its type, severity, and affected areas. It does not assign the final priority directly. Priority comes from deterministic arithmetic:

score = severity points × component weight + community-demand points
Signal Current treatment
Severity S0=100, S1=60, S2=30, S3=10. It captures impact and reach.
Component The highest matching area weight, currently 0.91.4.
Community demand GitHub +1 reactions add up to 15 points, capped at 12 reactions.
Needs information An issue labeled needs-info scores zero until the missing information arrives.

Scores map to priority labels as follows:

Priority Score
P0-critical 100 or higher
P1-high 6099.99
P2-medium 2559.99
P3-low Below 25

Age, readiness, and duplicate-count adjustments are not currently enabled. Component importance is a separate signal, so severity is not raised merely because an issue affects a particular harness or subsystem.

Maintainers can correct severity, component, or priority labels when context is missing from the model. Automation preserves those overrides and does not replace a maintainer-set priority with its own proposal. The queue is rerun as issues change, while unchanged LLM classifications are reused.

For bugs, include the observed impact, reproduction steps, Omnigent version, platform, and affected harness or authentication mode. For feature requests, describe the user problem and expected reach. Use a +1 reaction when an existing issue matters to you; ordinary comments are not counted as votes.

The scoring configuration and component map are public in default_scoring.json and areas.json.

Development setup

This is a Python package with an optional frontend under web/. Use uv for local development:

Supported dev OS: macOS or Linux. Native Windows is not supported for development — some test dependencies are POSIX-only (pexpect/pyte are excluded on Windows), a few modules import POSIX stdlib or call os.getuid() at import time, and the pre-commit hooks assume the Unix .venv/bin/ layout, so pytest and pre-commit cannot pass natively. On Windows, use WSL2 (Ubuntu) and clone into the Linux filesystem (~/…, not /mnt/c); this matches CI. Git Bash is not sufficient — it runs native-Windows Python.

Install local prerequisites first:

  • uv for Python environments and dependency management.
  • tmux, required for native Claude/Codex terminals launched by the local host (brew install tmux on macOS, or apt install tmux on Debian/Ubuntu).
  • bubblewrap (bwrap), Linux only, used to OS-sandbox those native Claude/Codex/Pi terminals (apt install bubblewrap on Debian/Ubuntu). macOS uses the built-in seatbelt sandbox and needs nothing extra.
  • Node.js 22 LTS or newer with pnpm (install via corepack enable or npm install -g pnpm) when working on web/.
  • A Rust toolchain for the recommended omnidev local development supervisor.
git clone https://github.com/omnigent-ai/omnigent.git
cd omnigent

uv python install
uv venv --python "$(cat .python-version)"
uv sync --extra all --group dev
source .venv/bin/activate    # or prefix commands with `uv run`

Repository-only dependencies use PEP 735 groups: lint for static checks and code generation, test for pytest, and dev for both. Product capabilities remain installable extras. Plain uv sync installs neither group by default.

Common checks:

Pyrefly is the canonical Python type checker for the repository.

uv run --no-sync pytest                      # Python tests (e2e/live skipped by default)
uv run --no-sync ruff check . && uv run --no-sync ruff format --check .
uv run --no-sync pyrefly check               # Python type checking (core and client SDK)
uv run --no-sync pre-commit run --all-files

When touching web/:

cd web && pnpm install && pnpm run lint && pnpm run type-check && pnpm run build

When touching editors/vscode/:

cd editors/vscode && pnpm install && pnpm run type-check && pnpm run test && pnpm run build

Running locally

Start with the smallest relevant automated test described in Tests. For full-stack manual testing, use omnidev.

omnidev runs the current checkout's server, host, and Vite frontend in one terminal. Each checkout path, including each worktree, gets isolated state, configuration, database, artifacts, logs, and automatically allocated ports, so it can run alongside your normal Omnigent installation and other worktrees.

Install the supervisor once from an up-to-date checkout:

cargo install --path dev/omnidev --force

Then run it from anywhere inside the branch checkout or worktree you want to test. A fresh worktree needs its own Python environment first:

cd /path/to/omnigent-worktree
uv sync --extra all --group dev
omnidev

Open the exact ui URL displayed in the header; do not assume the Vite port is 5173. Python changes under omnigent/ reload the server and host, while frontend changes use Vite HMR.

Run CLI commands against the development pod through the passthrough so they use that checkout and its isolated state instead of a globally installed omnigent:

omnidev omnigent config show
omnidev omnigent agent list

Keep omnidev in the foreground and quit with q or Ctrl-C so it tears down all three processes. An interactive terminal inside an existing Omnigent session also works; use git rev-parse --show-toplevel to confirm that its current checkout is the one you intend to test.

See dev/omnidev/README.md for log controls, clean-state testing, backend-only and LAN modes, and other options.

Manual three-terminal fallback

Use the manual flow when you need to run or debug each component separately. Unlike omnidev, it does not isolate state or allocate ports. These commands assume the default ports are free:

# Terminal 1: local server on :6767
uv run omnigent server

# Terminal 2: register your machine as a host
uv run omnigent host --server http://localhost:6767

# Terminal 3: frontend dev server
cd web
pnpm run dev

Open the Vite URL from the frontend dev server, usually http://localhost:5173/. The host registration is what lets the web UI browse your filesystem and start new sessions on your machine — without it, the web UI is read/continue-only.

omni is an alias for omnigent, so omni host --server ... works too. The host URL can also be passed positionally (omnigent host http://localhost:6767). See the README for more on hosts, harnesses, and credentials.

Disposable backend-only validation

Use this when you want to validate the Python backend and local API server from a source checkout without building the web UI, configuring provider credentials, creating sessions, or running agents -- a quick server/API smoke check on your working copy or current main.

scripts/backend-smoke.sh automates it:

scripts/backend-smoke.sh              # boots on port 18080
PORT=18090 scripts/backend-smoke.sh   # override the port if 18080 is busy

It installs uv into a throwaway toolchain venv, runs uv sync --frozen, starts the server in API-only mode (OMNIGENT_SKIP_WEB_UI=true), waits for /health, and smoke-tests /, /health, /docs, /v1/agents, and /v1/sessions -- expecting HTTP 200 from all five. It exits non-zero if any check fails.

Notes:

  • Requires bash or zsh (the script's #!/usr/bin/env bash shebang guarantees this); it is not POSIX-sh portable. Also needs Python 3.12+ as python3, git, curl, and network access to PyPI. No provider credentials are needed. Works on Linux and macOS.
  • Fully isolated, disposable: every artifact -- the toolchain and project venvs, config, data, the SQLite database, artifacts, logs, and pip/uv caches -- lives under one mktemp -d runtime directory removed on exit, so the run never touches your real ~/.omnigent, ~/.config / ~/Library, or package caches. HOME is the primary isolation lever (it redirects ~/.config on Linux and ~/Library on macOS); the explicit UV_* / PIP_* / OMNIGENT_* overrides pin the toolchain and app state regardless of OS, and XDG_* are set so an XDG_* already exported in your shell cannot redirect state back to your real home.
  • What it does not cover: the web UI, mobile access, human-in-the-loop approval flows, provider-backed sessions, or agent execution. Use the full local development flow above when working on those areas.

Tests

A change that alters behaviour under omnigent/ should ship with a test, and a bug fix should add a test that fails before the fix. Pure refactors, renames, type-only changes, dependency bumps, and edits with no observable behaviour change don't need a new test.

Prefer the smallest test that covers the change. A fast, focused unit test in the area suite is the default and what most changes need. Reach for tests/integration/ only when behaviour genuinely spans components, and for tests/e2e/ only for full-stack flows that a unit test can't capture — these are slower and (for e2e) gateway-bound, so don't use them where a unit test would do.

Put the test in the suite that matches the area you changed — most backend areas mirror their source directory under tests/:

Area changed (omnigent/…) Test suite (tests/…)
server/ server/
runner/ runner/
runtime/ runtime/
tools/ tools/
inner/ inner/
llms/ llms/
db/ db/ (a schema migration especially warrants one)
policies/ policies/
repl/ repl/
entities/ entities/
stores/ stores/
host/ host/
spec/ spec/

Two cross-cutting suites sit on top of these:

  • tests/integration/ — behaviour that spans several components (e.g. server + runtime) and isn't captured by any single area's unit test.
  • tests/e2e/ — full-stack flows driven against a live LLM (sessions, the runtime, sub-agent dispatch, client-tool tunneling, transports, native harness bridges, steering/cancellation). These are slow and gateway-bound, so reserve them for genuine end-to-end behaviour — but a PR that adds new user-facing functionality must include at least one e2e happy-path test (see .github/copilot-instructions.md).

Frontend (web/)

Frontend changes follow the same expectation with a different toolchain:

  • Add or update a colocated Vitest test — a *.test.ts/*.test.tsx file next to the component or module you changed — and run it with pnpm test.
  • A change to user-facing UI behaviour also needs a Playwright test under tests/e2e_ui/. This one is enforced mechanically by the E2E UI Required check, so a UI PR won't merge without a covering test (or a maintainer waiver) — see .github/workflows/e2e-ui-required.yml.
  • Styling/formatting-only changes, copy tweaks with no flow change, and refactors with no behaviour change are exempt, same as the backend.

Developer Certificate of Origin

To contribute to this repository, you must sign off your commits to certify that you have the right to contribute the code and that it complies with the open source license. If you can certify the contents of the DCO, add a Signed-off-by line to each commit message:

Signed-off-by: Joe Smith <joe.smith@email.com>

Please use your real name — pseudonymous/anonymous contributions are not accepted. If your user.name and user.email git configs are set, git commit -s adds the sign-off automatically. The DCO check on every pull request enforces this, so unsigned commits will block merging.

Pull requests

  • Branch from main, keep changes focused, and include tests or docs when relevant.
  • Sign off your commits with git commit -s (see Developer Certificate of Origin above).
  • Reference an issue (see below).
  • Fill in the PR template. For UI / frontend changes, check the "UI / frontend change" box and attach a video or images in the Demo section showing the new behaviour, so reviewers can see it without checking out the branch.

Every PR needs an issue

We require an issue for every pull request. Issues are how work gets prioritized, so a PR without one arrives unsorted and waits longer.

Reference it in the description. Which keyword you use depends on whether the PR finishes the issue:

Your PR Write Effect
Finishes the issue Closes #123 (or Fixes / Resolves) GitHub links the PR and closes the issue on merge
Is one step towards it Part of #123 (or Related to / Towards / Refs) The issue stays open

Closes is preferred when it applies, because GitHub records a real link and closes the issue for you. For a partial change, do not claim Closes: use one of the second-row keywords instead, so the issue is not closed before the work is done. You can also link a closing issue from the Development section of the sidebar, which counts the same as a Closes keyword.

A bare #123 is not enough on its own. It creates a cross-reference rather than saying anything about this PR, so pair it with one of the keywords above. The reference also has to point at an issue: naming another pull request does not count, since a PR is not a tracking record.

No issue for your change yet? Open one first, then reference it. That is also the faster path for anything non-trivial: it lets a maintainer confirm the approach before you write code.

The only exceptions are changes with no user-visible behaviour: pure Refactor / chore, Docs, or Test / CI work. If that is genuinely what your PR is, check that box under Type of change and no issue is needed. Anything that fixes a bug, adds a feature, or changes the UI needs an issue, even when it also touches docs or tests.

A bot comments once on PRs that reference no issue. It never closes anything.

Review state labels

Two labels track whose turn it is. Both are managed by automation, so you do not need to apply them.

Label Meaning
waiting-on-author A maintainer has left feedback. The PR is in your court.
waiting-for-review You have responded. It is back in the reviewer's queue.

A maintainer reviewing or commenting on your PR sets waiting-on-author. When you push a commit, comment, or reply to a review, that clears automatically and waiting-for-review goes on instead, which also re-pings your reviewer. You do not need to ask for a re-review.

A PR left in waiting-on-author for 7 days with no reply or new commit is closed to keep the review queue readable. That is not a judgement on the change, and it is reversible: comment /reopen (see below).

As of 5 August 2026 maintainers follow this process for new pull requests. PRs opened before then are being worked through separately, so an older PR may not carry these labels yet; that does not mean it has been forgotten. The issue-link rule also applies only to PRs opened on or after that date, so you will not be asked to retrofit an issue onto an older PR.

Reopening a closed PR

If automation closed your PR (as a duplicate, for example) and you think that was wrong, comment /reopen on it and a bot will reopen it for you. GitHub only lets maintainers press the Reopen button, so this command is how you do it yourself. You can also use it on a PR you closed by hand.

Only the PR author can use it, and it won't override a maintainer who closed your PR deliberately; ask them in a comment instead. It also needs your source branch to still exist. If you deleted it, push it again and open a fresh PR linking the old one.