main
7 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
 Edwin He
|
9e5b8741d2 |
feat(cli): route host-scoped requests to the replica holding the host's tunnel (#4185)
Adds a per-host routing key (the ``X-Databricks-Omnigent-Slice-Key`` header) so that, on a horizontally-scaled multi-tenant deployment, every request scoped to a given host or session lands on the replica that holds that host's runner tunnel: the host's control tunnel, its runners' tunnels, and all of a session's turn/resource/stream traffic converge on one replica when they carry the same key (the host_id). On an unsharded / single-replica deployment the key is never emitted, so this is a no-op there. Client-side only. The key is built centrally in ``cli_auth.databricks_request_headers`` (gated on the workspace-hosted mount) and threaded through the one factory ``open_server_client`` plus ``_remote_headers`` / ``open_daemon_client``. Callers pass a host_id when they have one; runner-side callers (forwarders, permission checks) inherit it automatically from the ``OMNIGENT_RUNNER_SLICE_KEY`` env var the host stamps at runner launch, so no per-callsite change is needed there. The WebSocket attach handshake and its reconnects carry the same key. ``chat._remote_headers`` gains a ``host_id`` keyword (defaulting to ``None`` so probes and health checks are unaffected). ``_DatabricksTokenAuth`` resolves the session's host per request from the session→host map and can be repointed via ``pin_session`` when a client outlives its session (e.g. a ``--fork`` in the REPL lands under a new conversation id on a new host). Session-host state is always written on attach — clearing a stale mapping when the server reports no host matters as much as setting one. A ``tests/cli`` conftest fixture isolates the runner machine's own host identity so "no slice key on this call" assertions are hermetic regardless of whether the box running the suite is itself a host. Signed-off-by: Edwin He <41037314+Edwinhe03@users.noreply.github.com> |
||
|
Sabhya Chhabria
|
24831901e7 |
feat: import Qwen, Kiro, Pi, and Kimi chats (#3032)
* feat: import Qwen Kiro Pi and Kimi chats Signed-off-by: sabhya-db <sabhya.chhabria@databricks.com> * 🐛 fix(import): Harden JSONL adapter contracts - Expose stable Kiro and Kimi parser APIs for import reuse - Hash overlong source IDs and bound Qwen locators safely Signed-off-by: sabhya-db <sabhya.chhabria@databricks.com> --------- Signed-off-by: sabhya-db <sabhya.chhabria@databricks.com> Co-authored-by: sabhya-db <sabhya.chhabria@databricks.com> |
||
|
Pat Sukprasert
|
ad7d8d7abf |
feat(kiro-native): launch-time model picker in the Web UI (#1697) (#1715)
* feat(kiro-native): launch-time model picker in the Web UI (#1697) Surface kiro-cli's models in the Omnigent model picker, mirroring cursor-native (launch-only, static catalog). Picking a model persists model_override, which the runner applies as --model at launch. - kiro_native.py: _KIRO_BASE_MODELS + kiro_base_model_options() (the 9 ids from kiro-cli --list-models 2.10.0; auto is default). - server/routes/sessions.py: _fetch_model_options returns the static kiro catalog for the kiro-native wrapper (like cursor; not the runner endpoint). - runner/app.py: _KiroNativeLaunchConfig carries model_override; _kiro_native_launch_config reads+validates it; _auto_create_kiro_terminal passes it to build_kiro_launch(model=...). - web ChatPage.tsx: route kiro-native-ui through the server-model-options picker (kind "kiro"), surface model_override as the selected/effective model, and label it "Kiro". Effort stays hidden (kiro --effort deferred). Tests: kiro_base_model_options shape/default; capabilities (picker shown, effort hidden for kiro); an e2e that the picker renders the kiro catalog and a pick PATCHes model_override. Co-authored-by: Isaac * style(web): prettier-format the kiro capabilities test Format-only: the added kiro assertions weren't prettier-wrapped, failing the web-prettier pre-commit hook and the npm-test job's format check. Co-authored-by: Isaac * feat(kiro-native): live mid-session model switch via /model (#1697) Fold the launch-only picker into a live switch. On a mid-session model pick the server already forwards model_change to the runner (harness-agnostic); add the kiro dispatch branch so it types /model <id> into the live kiro TUI instead of only applying on the next launch. - kiro_native_bridge.inject_model_command: clears the draft, sends /model <id> literally, Enter, and confirms via kiro's 'Model changed to <id>' line so a bad id fails loudly (its own confirm timeout, since the switch takes ~2s). kiro switches directly (no picker), so this is simpler than cursor's variant. - runner: _handle_kiro_native_model_change + kiro-native branch in the model_change dispatch ladder, mirroring cursor-native. - Note: kiro persists the switch as its global default ('saved as default'). Co-authored-by: Isaac * test(kiro-native): cover model_change dispatch -> live /model switch (#1697) POST /events model_change on a kiro-native session routes through the runner dispatch ladder to _handle_kiro_native_model_change -> inject_model_command. Mirrors test_events_model_change_on_native_session_types_slash_command. Co-authored-by: Isaac * fix(kiro-native): mirror the live model to the web so the picker shows it (#1697) At launch model_override was empty, so the picker fell back to the harness name ("Kiro") instead of the current model. The forwarder now reads kiro's model_id from the session .json (rts_model_state.model_info.model_id, independent of metering so it's available before the first turn) and mirrors it via external_model_change -> model_override. The server persists it without re-forwarding /model (no loop), mirroring cursor-native's terminal->web mirror. This shows the real model at launch (e.g. Auto) and reflects TUI-direct /model switches too. Co-authored-by: Isaac * fix(web): show kiro's catalog default in the launch window, not the harness name (#1697) Before the forwarder mirrors kiro's live model, model_override is empty and the picker trigger fell back to the agent name ("Kiro"), which reads oddly as a model label. For kiro, prefer the catalog default (e.g. "Auto") as the launch-window fallback so the trigger clearly reads as a model. Scoped to kiro; cursor/codex unaffected. Co-authored-by: Isaac |
||
|
Pat Sukprasert
|
08f7d20707 |
feat(kiro-native): forward credit usage as session cost (#1696) (#1699)
kiro-cli meters in credits (not tokens), recorded per-turn under session_state.conversation_metadata.user_turn_metadatas[*].metering_usage in the session .json snapshot; the forwarder only tailed the .jsonl transcript, so Omnigent showed no cost for kiro sessions. Sum the per-turn credit values and post the cumulative total as external_session_usage cumulative_cost_usd (the monotonic, authoritative cost path the claude-/codex-native forwarders use). Credits are forwarded 1:1 into cost_usd since no credit->USD conversion exists, matching the Copilot AI-credit convention; documented in the helper. Co-authored-by: Isaac |
||
|
Daniel
|
d0876061ce |
fix(kiro-native): bind session forwarder only when exactly one candidate (#1137) (#1532)
* fix(kiro-native): bind session forwarder only when exactly one candidate (#1137) `_discover_kiro_session_jsonl` picked the newest-by-`updated_at` among same-workspace Kiro sessions created after the launch floor, with no uniqueness guard. Each Kiro session is its own JSONL, so two fresh sessions launched in the same workspace within the discovery window both qualify — and newest-by- `updated_at` can latch onto the *other* session's transcript and silently cross-talk it into this conversation. Bind only when exactly one session qualifies; with two or more, return None and retry rather than guess. A brief delay is safe; mirroring the wrong conversation is not. Mirrors cursor-native's "bind only when exactly one chat qualifies". The resume/fork path is unaffected — it binds the known id directly via `_kiro_session_jsonl_for_id`. Part of #1137. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Daniel Granados Campos <granadoscampos.daniel@gmail.com> * fix(kiro-native): harden session discovery ambiguity (#1137) Address review nits on the exactly-one bind guard: - Require a parseable created_at at/after the launch floor so an undateable same-workspace straggler can't inflate the candidate count and silently block discovery forever. - Warn once per distinct competing-candidate set on the >=2 branch so "ambiguous, won't bind" is diagnosable and distinct from "not written yet", without spamming the ~0.7s poll loop. Co-authored-by: Isaac --------- Signed-off-by: Daniel Granados Campos <granadoscampos.daniel@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Dhruv Gupta <dhruv.gupta@databricks.com> |
||
|
Daniel
|
246cb4d736 |
fix(kiro-native): single status source; stop forwarder double-posting (#1137) (#1491)
kiro-native posted session status from two places: the PTY-watcher emit_status set (resource_registry.py) and the session forwarder (external_session_status on user->running / assistant->idle). Drop the forwarder's status posting so the PTY watcher is the sole source, matching goose/qwen/hermes whose forwarders mirror transcript only. Part of #1137. |
||
|
Michael Gardner
|
6f0257dbc7 |
feat(kiro): add native CLI harness (#899)
* feat: add Kiro native CLI harness Signed-off-by: Michael Gardner <gardnmi@gmail.com> * fix(kiro): avoid ambient env in tmux attach Signed-off-by: Michael Gardner <gardnmi@users.noreply.github.com> * fix: restore uv.lock pypi.org sources (drop accidental databricks-proxy re-lock) A local `uv run` during the merge re-locked uv.lock against this machine's Databricks-internal pypi proxy, flipping every package source URL. Kiro changes no dependencies and pyproject.toml is unchanged vs main, so restore main's uv.lock verbatim (pypi.org sources). Only registry URLs differed — no version or hash changes. Co-authored-by: Isaac * test(e2e-ui): add native-kiro render-parity suite (E2E UI Required gate) The E2E UI Required gate flagged that #899 changes the agent-picker/session UI (adds Kiro) without a tests/e2e_ui/** test. Add test_native_kiro_render_parity.py mirroring the cursor/goose siblings — composer-IN parity, a TUI-originated turn surfacing OUT, and no duplicate rendering — plus the native_kiro_session fixture. Skip-gated on kiro-cli + tmux, so it skips in CI (no Kiro account provisioned) exactly like the goose/cursor suites, and runs for real where Kiro is signed in. Verified: collects + skips cleanly (kiro-cli absent); ruff clean. Co-authored-by: Isaac * fix: restore ap-web/package-lock.json npmjs.org sources (drop databricks npm-proxy) Same root cause as the uv.lock fix: an npm command during round-1 merge re-resolved one dependency (yaml-1.10.3) against this machine's Databricks-internal npm proxy (npm-proxy.cloud.databricks.com), which CI (pinned to registry.npmjs.org) can't reach -> 'npm ci' ETIMEDOUT. ap-web/package.json is unchanged vs main and Kiro adds no npm dependency, so restore main's package-lock.json verbatim (clean npmjs.org sources). Co-authored-by: Isaac * test(e2e): exclude kiro-native from the live-harness matrix coverage check test_run_harness_live_matrix_covers_registered_coding_harnesses asserts every registered coding harness is either in the live no-AGENT e2e matrix or explicitly excluded. kiro-native is a terminal-first TUI launched via `omni kiro` (tmux pane + bridge dir), not `omnigent run --harness kiro-native`, so — like goose-native / qwen-native / cursor-native — it can't run in this matrix. Add it to the exclusion set with the matching rationale; its coverage is the kiro-native bridge/executor/ forwarder unit tests + the test_native_kiro_render_parity e2e_ui suite. Co-authored-by: Isaac * test(ap-web): set isNativeWrapper in /compact composer menu tests #1139 gated "/compact" behind isNativeWrapper (hidden for non-native harnesses), but the three slash-menu-UX tests that assert "/compact" tops/appears in the suggestions still rendered a non-native composer, so they now fail on main (and on every PR that merges main). Render those three with isNativeWrapper:true so "/compact" is offered, restoring the built-in ordering the tests pin. Test-only; no behavior change. Fixes the inherited ChatPage.composer.test.tsx red on this PR. Co-authored-by: Isaac * test(kiro): cover kiro_native launcher helpers (raise coverage 43%→70%) The kiro-native launcher (omnigent/kiro_native.py) was the largest coverage gap on this PR: its CLI/daemon orchestration is only exercised by the live render-parity e2e, which skips in CI when kiro-cli is absent. Add focused unit tests (with a fake httpx client) for the unit-testable surface: executable resolution, launch-argv assembly, terminal-payload decoding, tmux attach gating, startup-progress forwarding, preflight, resume-id resolution, and the create/fetch/ ensure/find/wait session helpers (success + error branches). Lifts kiro_native.py from 43% to 70%; remaining misses are the daemon-driven async orchestration covered by runner/e2e paths. Co-authored-by: Isaac * test(kiro): rename test env var to avoid exfil-scan false positive The CI exfil scanner flags any added file containing a secret-named source (regex `[A-Z0-9]+_SECRET\b`) together with a network sink. The tmux-allowlist test used `OMNIGENT_SECRET` purely as a non-allowlisted sample var, which matched the secret regex and — combined with the fake httpx client's .post()/.get() in the same file — tripped the "secret-named source + network sink" block. Rename it to a neutral `OMNIGENT_UNLISTED_VAR`; the test's intent (filtering non-allowlisted keys) is unchanged. Co-authored-by: Isaac --------- Signed-off-by: Michael Gardner <gardnmi@gmail.com> Signed-off-by: Michael Gardner <gardnmi@users.noreply.github.com> Co-authored-by: Pat Sukprasert <pattara.sk127@gmail.com> |