Jason Jean
951cd8b9d4
## Current Behavior
The e2e suite is slow and intermittently flaky, driven by a few
infrastructure issues:
- **Lazy dependency installs.** Generator dependencies (test runners,
bundlers, framework plugins) are
installed on demand during a test via `ensurePackage()`. This pushes
install cost into the middle of
the run and makes timing vary run-to-run.
- **Port collisions.** Tests pick ports semi-randomly
(`getRandomPort()`) from overlapping ranges and
don't coordinate across parallel e2e processes, so concurrent tests can
grab the same port and fail
with `EADDRINUSE`. Module federation tests also need a contiguous block
of ports (host + remotes) that
the old scheme couldn't guarantee.
- **Fixed-sleep races.** Some tests start a built app, `sleep 1`, then
assert on its output — which
loses the race on a loaded CI machine where boot + module evaluation
takes several seconds.
- **CI agent contention.** Module federation e2e tasks each build and
serve a host plus its remotes
(multiple webpack/rspack builds at once), saturating an agent; running
them alongside other e2e at
high parallelism caused timeouts.
## Expected Behavior
Faster and more deterministic e2e runs:
- **Pre-install generator deps up front.** Each `newProject({ packages:
[...] })` now declares every
plugin the test will use, so installs happen once during setup instead
of lazily mid-test.
- **Robust port reservation** (`e2e/utils/port-utils.ts`): lock files
are stamped with the owning PID,
abandoned locks are reclaimed (developer machines only — CI containers
are ephemeral), the scan
origin is randomized so parallel processes scatter instead of converging
on low ports, and
`reservePorts(count)` returns a contiguous run for module federation.
`getRandomPort()` is deprecated
in favor of `reservePort()`.
- **Poll-until-ready** instead of fixed sleeps — a built app is polled
for its "server ready" line (up
to 30s) before assertions.
- **CI tuning** (`.nx/workflows/dynamic-changesets.yaml`): module
federation e2e is pinned to
`linux-extra-large` at parallelism 1; remaining e2e runs at 3 (large) /
6 (extra-large).
- **Install visibility**: `installPackagesTask` now logs the install
command and how long it took.
## Related Issue(s)
Fixes #
---------
Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>
95 lines
2.8 KiB
Batchfile
95 lines
2.8 KiB
Batchfile
@rem
|
|
@rem Copyright 2015 the original author or authors.
|
|
@rem
|
|
@rem Licensed under the Apache License, Version 2.0 (the "License");
|
|
@rem you may not use this file except in compliance with the License.
|
|
@rem You may obtain a copy of the License at
|
|
@rem
|
|
@rem https://www.apache.org/licenses/LICENSE-2.0
|
|
@rem
|
|
@rem Unless required by applicable law or agreed to in writing, software
|
|
@rem distributed under the License is distributed on an "AS IS" BASIS,
|
|
@rem WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
@rem See the License for the specific language governing permissions and
|
|
@rem limitations under the License.
|
|
@rem
|
|
@rem SPDX-License-Identifier: Apache-2.0
|
|
@rem
|
|
|
|
@if "%DEBUG%"=="" @echo off
|
|
@rem ##########################################################################
|
|
@rem
|
|
@rem Gradle startup script for Windows
|
|
@rem
|
|
@rem ##########################################################################
|
|
|
|
@rem Set local scope for the variables with windows NT shell
|
|
if "%OS%"=="Windows_NT" setlocal
|
|
|
|
set DIRNAME=%~dp0
|
|
if "%DIRNAME%"=="" set DIRNAME=.
|
|
@rem This is normally unused
|
|
set APP_BASE_NAME=%~n0
|
|
set APP_HOME=%DIRNAME%
|
|
|
|
@rem Resolve any "." and ".." in APP_HOME to make it shorter.
|
|
for %%i in ("%APP_HOME%") do set APP_HOME=%%~fi
|
|
|
|
@rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
|
|
set DEFAULT_JVM_OPTS="-Xmx64m" "-Xms64m"
|
|
|
|
@rem Find java.exe
|
|
if defined JAVA_HOME goto findJavaFromJavaHome
|
|
|
|
set JAVA_EXE=java.exe
|
|
%JAVA_EXE% -version >NUL 2>&1
|
|
if %ERRORLEVEL% equ 0 goto execute
|
|
|
|
echo. 1>&2
|
|
echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. 1>&2
|
|
echo. 1>&2
|
|
echo Please set the JAVA_HOME variable in your environment to match the 1>&2
|
|
echo location of your Java installation. 1>&2
|
|
|
|
goto fail
|
|
|
|
:findJavaFromJavaHome
|
|
set JAVA_HOME=%JAVA_HOME:"=%
|
|
set JAVA_EXE=%JAVA_HOME%/bin/java.exe
|
|
|
|
if exist "%JAVA_EXE%" goto execute
|
|
|
|
echo. 1>&2
|
|
echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME% 1>&2
|
|
echo. 1>&2
|
|
echo Please set the JAVA_HOME variable in your environment to match the 1>&2
|
|
echo location of your Java installation. 1>&2
|
|
|
|
goto fail
|
|
|
|
:execute
|
|
@rem Setup the command line
|
|
|
|
set CLASSPATH=
|
|
|
|
|
|
@rem Execute Gradle
|
|
"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar" %*
|
|
|
|
:end
|
|
@rem End local scope for the variables with windows NT shell
|
|
if %ERRORLEVEL% equ 0 goto mainEnd
|
|
|
|
:fail
|
|
rem Set variable GRADLE_EXIT_CONSOLE if you need the _script_ return code instead of
|
|
rem the _cmd.exe /c_ return code!
|
|
set EXIT_CODE=%ERRORLEVEL%
|
|
if %EXIT_CODE% equ 0 set EXIT_CODE=1
|
|
if not ""=="%GRADLE_EXIT_CONSOLE%" exit %EXIT_CODE%
|
|
exit /b %EXIT_CODE%
|
|
|
|
:mainEnd
|
|
if "%OS%"=="Windows_NT" endlocal
|
|
|
|
:omega
|