github-featured / nrwl--nx

发布

0 发布 1,252 Git 标签

RSS 订阅源
  • 23.0.0-rc.3 4567848206
    比较

    fix(core): do not fail local plugin lookup when workspace has no root tsconfig (#35969)

    frostbyte_neo 发布于 2026-06-12 16:28:59 +00:00

    Current Behavior

    In a workspace that has no root tsconfig.base.json /
    tsconfig.json     — packages wired purely through package-manager
    workspaces and package.json exports — every workspace-local plugin
    listed in nx.json fails to load:

     NX   Failed to load 6 Nx plugin(s):

  - @scope/my-plugin: unable to find tsconfig.base.json or tsconfig.json
  ...

    This affects the latest stable release, not just the 23 RCs. The
    source-first local plugin resolution was backported to the 22.x line in
    22.7.3. Verified against the published dists of every version in
    between:

    nx version symlinked local plugin, no root tsconfig
    22.7.1 ✅ works
    22.7.2 ✅ works
    22.7.3 ❌ broken (backport of #35631 / #35751 lands)
    22.7.4 ❌ broken
    22.7.5 (latest) ❌ broken
    23.0.0-rc.0 (next) ❌ broken
    22.7.5 + this fix ✅ works

    Since the source-first local plugin resolution (#35631, #35751),
    resolveNxPlugin runs lookupLocalPlugin for any plugin whose
    require.resolve lands inside the workspace (true for every symlinked
    workspace package). findNxProjectForImportPath then calls
    readTsConfigPaths, which throws when no root tsconfig exists —
    aborting the whole plugin load before the function ever reaches its
    tsconfig-independent fallbacks (package-metadata matching, then Node
    resolution of the built artifact).

    Minimal reproduction (5 files, released nx@22.7.5)

    // package.json
{ "name": "repro", "private": true, "devDependencies": { "nx": "22.7.5" } }

    # pnpm-workspace.yaml
packages:
  - 'packages/*'

    // nx.json
{ "plugins": ["@repro/my-plugin"] }

    // packages/my-plugin/package.json
{ "name": "@repro/my-plugin", "exports": { ".": { "default": "./dist/index.js" } } }

    // packages/my-plugin/dist/index.js
module.exports.createNodesV2 = ['**/never-matches.xyz', async () => []];

    pnpm install && pnpm exec nx show projects →

     NX   Failed to load 1 Nx plugin(s):

  - @repro/my-plugin: unable to find tsconfig.base.json or tsconfig.json

    With this PR's change applied to
    dist/src/project-graph/plugins/resolve-plugin.js in the same install:
    exit 0, projects list as expected.

    Expected Behavior

    A missing root tsconfig just means the workspace has no tsconfig path
    mappings. readTsConfigPaths returns an empty mapping,
    findNxProjectForImportPath falls through to
    getWorkspacePackagesMetadata matching, and plugin resolution proceeds
    exactly as before the change (source via exports conditions when
    present, built dist otherwise).

    This matches the function's own tolerance for a tsconfig without
    compilerOptions.paths (return tsconfigPaths ?? {}).

    Given the 22.x backport, a backport of this fix to the 22.x line would
    also be appreciated.

    Related Issue(s)

    Fixes #35970

    Standalone repro (5 files, released nx@22.7.5):
    https://github.com/agcty/nx-repro-local-plugin-no-root-tsconfig

    Regression introduced with the source-first local plugin resolution
    (#35631 / #35751), present in 23.0.0-rc.0 and backported into the
    stable line in 22.7.3 (22.7.2 and below unaffected). Originally
    encountered upgrading a bun-workspaces monorepo (six local inference
    plugins, per-package tsconfigs, no root tsconfig) from 22.7.1 to
    23.0.0-rc.0 — all nx commands fail at plugin load. Additionally
    verified end-to-end: in the affected workspace, with this change
    applied, all 57 projects and all six local plugins load and tasks run;
    the new unit test fails with exactly the pre-fix error when the source
    change is reverted.

    Co-authored-by: Jason Jean jason@nrwl.io

    下载附件