github-featured / nrwl--nx

发布

0 发布 1,252 Git 标签

RSS 订阅源
  • 23.0.0-beta.7 b07804182d
    比较

    chore(testing): split NX_E2E_SKIP_CLEANUP into global/project-scoped vars (#35572)

    frostbyte_neo 发布于 2026-05-05 14:45:18 +00:00

    Current Behavior

    NX_E2E_SKIP_CLEANUP is set to 'true' in every Linux/macOS e2e matrix
    entry to gate the build-cache reuse check in e2e/utils/global-setup.ts
    (skip wiping e2eCwd + republishing to verdaccio when ./build already
    exists).

    PR #35042 added an early-return to cleanupProject in
    e2e/utils/create-project-utils.ts guarded by the same env var name to
    expose a local debug opt-in (preserve the per-test tmp project for
    inspection). Because CI already had the var set, the new early-return
    fires on every CI run, silently disabling the per-test nx reset +
    tmpProjPath() removal that previously kept orphan daemons from
    leaking. Jest hangs after all tests pass and the workflow times out at
    60 minutes.

    Expected Behavior

    Each lifecycle hook is gated by a distinct, scope-specific env var:

    • NX_E2E_SKIP_GLOBAL_CLEANUP — global-setup.ts (CI sets it).
    • NX_E2E_SKIP_PROJECT_CLEANUP — cleanupProject (developer-set locally
      for debugging only).

    Per-test cleanup runs in CI again, jest exits cleanly, and nightly e2e
    jobs no longer hit the 60-minute cap.

    Validation

    Verified via a manually-dispatched e2e nightly run on this branch (with
    the matrix temporarily narrowed to Linux/{npm,pnpm,yarn}/20 e2e-node,
    the matrix that hung at 60 min on master):
    https://github.com/nrwl/nx/actions/runs/25375231501 — all 3 jobs passed
    in ~25 minutes each.

    Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com>

    下载附件