Files
modelcontextprotocol--pytho…/tests/docs_src/test_deprecated.py
Max Isbey ab89da82ba Keep unexpected exception text out of tool results
A tool that crashed used to send the exception's own text to the client
as "Error executing tool <name>: <str(exc)>". That text can describe
server internals (or, for an output-schema failure, echo the tool's
return value), so a crash now reads just "Error executing tool <name>".
ToolError, ResourceError, and argument-validation messages still reach
the model unchanged, since those are the anticipated failures it can act
on. Closes the tool half of the leak that resources already avoided and
that prompts stopped doing earlier in this branch.

Related tidy-ups in the same direction:
- a crashing @mcp.completion() handler is logged once and answered with
  -32603 "Error completing argument <name>" instead of str(exc)
- the legacy resolver path reports a malformed elicitation answer as a
  ToolError, matching what the input_required path already did
- the INFO line for rejected arguments names the fields, not the values

Docs now teach ToolError as the way to talk to the model and describe a
plain exception as a crash the model sees generically; examples that
relied on ValueError text reaching the client raise ToolError instead.
2026-08-20 14:56:47 +00:00

151 lines
6.5 KiB
Python

"""`docs/deprecated.md`: the page's behavioural claims, executed against the live SDK.
This chapter has no `docs_src/` example by design: it is the one page allowed to name
the deprecated methods, and a runnable example would teach exactly what the page tells
the reader not to build. So instead of importing an example, each test here runs a
claim the page states in prose (the warning category and text, the warn-*then*-raise
order on a modern connection, the `ping` removal, and both `filterwarnings` recipes)
so the prose cannot drift away from what the SDK does.
"""
import logging
import warnings
import pytest
from mcp_types import CreateMessageRequestParams, CreateMessageResult, SamplingMessage, TextContent
from mcp import Client, MCPDeprecationWarning, MCPError
from mcp.client import ClientRequestContext
from mcp.server import MCPServer
from mcp.server.mcpserver import Context
from mcp.shared.exceptions import NoBackChannelError
pytestmark = pytest.mark.anyio
mcp = MCPServer("Deprecated")
@mcp.tool()
async def ask_model(prompt: str, ctx: Context) -> str:
"""A tool still built on server-initiated sampling."""
result = await ctx.session.create_message( # pyright: ignore[reportDeprecated]
messages=[SamplingMessage(role="user", content=TextContent(type="text", text=prompt))],
max_tokens=8,
)
return str(result.content)
@mcp.tool()
async def old_log(ctx: Context) -> str:
"""A tool still built on protocol logging."""
await ctx.info("hello") # pyright: ignore[reportDeprecated]
return "ok"
async def test_create_message_warns_and_then_raises_on_a_modern_connection() -> None:
"""The `!!! warning`: on a modern connection sampling warns AND THEN the send raises.
The two signals are independent: `@deprecated` fires the moment the method is
called, and only afterwards does the channel refuse the send. The page reports
both, in that order.
"""
async with Client(mcp) as client:
with (
pytest.warns(
MCPDeprecationWarning,
match=r"^The sampling capability is deprecated as of 2026-07-28 \(SEP-2577\)\.$",
),
pytest.raises(NoBackChannelError) as exc,
):
await client.call_tool("ask_model", {"prompt": "hi"})
assert str(exc.value) == (
"Cannot send 'sampling/createMessage': "
"this transport context has no back-channel for server-initiated requests."
)
async def test_a_deprecated_feature_still_works_on_a_legacy_session() -> None:
"""The page's headline: the deprecation is advisory.
On a classic-handshake session, the same `ask_model` tool that fails on a modern
connection runs to completion: sampling round-trips through the client's callback
and the result comes back. The only difference is the visible warning.
"""
async def canned_sampling(context: ClientRequestContext, params: CreateMessageRequestParams) -> CreateMessageResult:
return CreateMessageResult(
role="assistant",
content=TextContent(type="text", text="four"),
model="canned",
stop_reason="endTurn",
)
async with Client(mcp, mode="legacy", sampling_callback=canned_sampling) as client:
with pytest.warns(MCPDeprecationWarning, match=r"The sampling capability is deprecated"):
result = await client.call_tool("ask_model", {"prompt": "What is 2 + 2?"})
assert not result.is_error
[content] = result.content
assert isinstance(content, TextContent)
assert "four" in content.text
async def test_send_ping_still_carries_the_deprecation_warning() -> None:
"""The opening sentence: every retired method carries an `MCPDeprecationWarning`.
`ping` is removed from the 2026-07-28 protocol rather than put in a deprecation
window, but the SDK method is still decorated (its message says *removed*) and
a modern connection answers the actual request with "Method not found".
"""
async with Client(mcp) as client:
with (
pytest.warns(
MCPDeprecationWarning,
match=r"^ping is removed as of 2026-07-28; the method only works under mode='legacy'\.$",
),
pytest.raises(MCPError, match="^Method not found$"),
):
await client.send_ping() # pyright: ignore[reportDeprecated]
def test_mcp_deprecation_warning_is_a_user_warning() -> None:
"""The "Deprecated is advisory" section: the category subclasses `UserWarning`.
Python's default filter hides `DeprecationWarning` outside `__main__`; deriving
from `UserWarning` is what makes the warning visible with no `-W` flag.
"""
assert issubclass(MCPDeprecationWarning, UserWarning)
assert not issubclass(MCPDeprecationWarning, DeprecationWarning)
@pytest.mark.filterwarnings("error::mcp.MCPDeprecationWarning")
async def test_error_filter_turns_the_deprecated_call_into_the_documented_tool_error(
caplog: pytest.LogCaptureFixture,
) -> None:
"""The `!!! check`: `"error::mcp.MCPDeprecationWarning"` makes `old_log` fail.
Under the error filter the warning becomes the raised exception, the tool wrapper treats it as a
crash, and the result plus the logged warning are exactly what the page quotes.
"""
caplog.set_level(logging.ERROR, logger="mcp.server.mcpserver.server")
async with Client(mcp) as client:
result = await client.call_tool("old_log", {})
assert result.is_error
[content] = result.content
assert isinstance(content, TextContent)
assert content.text == "Error executing tool old_log"
(record,) = [r for r in caplog.records if r.name == "mcp.server.mcpserver.server"]
assert record.exc_info is not None and isinstance(record.exc_info[1], BaseException)
assert str(record.exc_info[1].__cause__) == "The logging capability is deprecated as of 2026-07-28 (SEP-2577)."
assert type(record.exc_info[1].__cause__).__name__ == "MCPDeprecationWarning"
async def test_filterwarnings_ignore_silences_the_whole_category() -> None:
"""The "Silencing the warning" snippet: one `filterwarnings` line quiets the category."""
async with Client(mcp) as client:
with warnings.catch_warnings(record=True) as caught:
warnings.simplefilter("always")
warnings.filterwarnings("ignore", category=MCPDeprecationWarning)
result = await client.call_tool("old_log", {})
assert not result.is_error
assert not any(issubclass(w.category, MCPDeprecationWarning) for w in caught)