The test_command_execution test was an integration test disguised as a unit
test. It executed external commands (uv run) which caused several problems:
- Modified uv.lock file as a side effect
- Required external dependencies (uv binary, network access)
- Was slow and potentially flaky
- Tested the wrong layer (uv CLI instead of config generation)
Replaced with 15 comprehensive unit tests that properly test the
update_claude_config function's actual responsibilities:
- JSON structure generation
- Argument array construction
- Path resolution to absolute paths
- Environment variable merging
- Package deduplication
- Server preservation and updates
- Error handling
Benefits:
- Fast: runs in ~1.5s vs several seconds
- No external dependencies or side effects
- Tests the correct abstraction layer
- Better coverage of edge cases
- More maintainable and reliable
Max Isbey
9853ce73ce