Asim Aslam
3e885308a0
Fixes #2988. Brings 'golangci-lint run ./...' to zero issues (was ~373): - errcheck: explicitly ignore fire-and-forget calls with '_ =' (and a small errcheck.exclude-functions list for response writes — json Encoder.Encode, http ResponseWriter.Write, fmt.Fprint*); genuine cases handled. - unused: remove dead code (unexported decls and dead test helpers) and the imports they orphaned. - staticcheck: ST1005 error strings, ST1016 receiver names, S1000/S1017/S1019/ S1023 simplifications, SA4004/SA4006/SA4010 dead code, SA1021 net.IP.Equal, SA6002 (store *[]byte in sync.Pool). - govet: fix a context leak (lostcancel) in internal/util/mdns and move t.Fatal/Fatalf out of goroutines (testinggoroutine) in tests. - ineffassign, unconvert: mechanical fixes. CI: the Lint workflow now runs a blocking full-tree 'golangci-lint run' on pushes and PRs (dropped only-new-issues now that the tree is clean). Verified: go build, go vet, test compilation, and unit tests for the behaviourally-touched packages all pass. Claude-Session: https://claude.ai/code/session_01CmdEY7pYmV5zzwCjNJ4ykL Co-authored-by: Claude <noreply@anthropic.com>
85 lines
1.5 KiB
Go
85 lines
1.5 KiB
Go
package jsonrpc
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"io"
|
|
|
|
"go-micro.dev/v6/codec"
|
|
)
|
|
|
|
type serverCodec struct {
|
|
dec *json.Decoder // for reading JSON values
|
|
enc *json.Encoder // for writing JSON values
|
|
c io.Closer
|
|
|
|
// temporary work space
|
|
req serverRequest
|
|
}
|
|
|
|
type serverRequest struct {
|
|
ID interface{} `json:"id"`
|
|
Params *json.RawMessage `json:"params"`
|
|
Method string `json:"method"`
|
|
}
|
|
|
|
type serverResponse struct {
|
|
ID interface{} `json:"id"`
|
|
Result interface{} `json:"result"`
|
|
Error interface{} `json:"error"`
|
|
}
|
|
|
|
func newServerCodec(conn io.ReadWriteCloser) *serverCodec {
|
|
return &serverCodec{
|
|
dec: json.NewDecoder(conn),
|
|
enc: json.NewEncoder(conn),
|
|
c: conn,
|
|
}
|
|
}
|
|
|
|
func (r *serverRequest) reset() {
|
|
r.Method = ""
|
|
if r.Params != nil {
|
|
*r.Params = (*r.Params)[0:0]
|
|
}
|
|
if r.ID != nil {
|
|
r.ID = nil
|
|
}
|
|
}
|
|
|
|
func (c *serverCodec) ReadHeader(m *codec.Message) error {
|
|
c.req.reset()
|
|
if err := c.dec.Decode(&c.req); err != nil {
|
|
return err
|
|
}
|
|
m.Method = c.req.Method
|
|
m.Id = fmt.Sprintf("%v", c.req.ID)
|
|
c.req.ID = nil
|
|
return nil
|
|
}
|
|
|
|
func (c *serverCodec) ReadBody(x interface{}) error {
|
|
if x == nil {
|
|
return nil
|
|
}
|
|
var params [1]interface{}
|
|
params[0] = x
|
|
return json.Unmarshal(*c.req.Params, ¶ms)
|
|
}
|
|
|
|
func (c *serverCodec) Write(m *codec.Message, x interface{}) error {
|
|
var resp serverResponse
|
|
resp.ID = m.Id
|
|
resp.Result = x
|
|
if m.Error == "" {
|
|
resp.Error = nil
|
|
} else {
|
|
resp.Error = m.Error
|
|
}
|
|
return c.enc.Encode(resp)
|
|
}
|
|
|
|
func (c *serverCodec) Close() error {
|
|
return c.c.Close()
|
|
}
|