Copilot
99bd642db9
* Initial plan
* fix(web): digest post returns real GitHub Issue URL instead of false ok:true
The admin digest "post" action was returning `{ ok: true, action: "digest-skipped" }`
without posting anything or marking the draft as posted. This caused the draft to
reappear in Pending forever — a false success receipt.
Fix: digest drafts are now posted as new GitHub Issues (using the existing
MAINTAINER_GITHUB_PAT + REST API). The response includes the real issue
`number` and `url`; `draft.posted` is set to true and the draft is stored back.
GitHub API failures propagate as 502 errors, never as ok:true.
Tests: two new source-contract tests in public-api-security.test.ts pin both
paths — happy path (real url/number returned) and error path (502, not ok:true).
Closes #5178
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
77 lines
3.4 KiB
TypeScript
77 lines
3.4 KiB
TypeScript
import { readFileSync } from "node:fs";
|
|
import { describe, expect, it } from "vitest";
|
|
|
|
function routeSource(path: string): string {
|
|
return readFileSync(new URL(`../app/api/${path}/route.ts`, import.meta.url), "utf8");
|
|
}
|
|
|
|
function librarySource(path: string): string {
|
|
return readFileSync(new URL(path, import.meta.url), "utf8");
|
|
}
|
|
|
|
describe("public API security contracts", () => {
|
|
it("keeps the unauthenticated feed cached and detached from the server token", () => {
|
|
const source = routeSource("github/feed");
|
|
expect(source).toContain('export const dynamic = "force-static"');
|
|
expect(source).toContain("fetchFeed(undefined, 50)");
|
|
expect(source).not.toContain("GITHUB_TOKEN");
|
|
expect(source).not.toContain('dynamic = "force-dynamic"');
|
|
});
|
|
|
|
it("validates the draft namespace before admin discard can reach KV", () => {
|
|
const source = routeSource("admin/post");
|
|
expect(source).toContain("parseDraftKey(draftKey)");
|
|
expect(source.indexOf("parseDraftKey(draftKey)")).toBeLessThan(
|
|
source.indexOf("getDraft(env.CURATED_KV, draftKey)"),
|
|
);
|
|
expect(source.indexOf("getDraft(env.CURATED_KV, draftKey)")).toBeLessThan(
|
|
source.indexOf("deleteDraft(env.CURATED_KV, draftKey)"),
|
|
);
|
|
});
|
|
|
|
it("bounds the public login body before comparing the maintainer token", () => {
|
|
const source = routeSource("admin/login");
|
|
expect(source).toContain("readBoundedUrlEncodedForm(req, MAX_LOGIN_BODY_BYTES)");
|
|
expect(source).not.toContain("req.formData()");
|
|
expect(source.indexOf("readBoundedUrlEncodedForm(req, MAX_LOGIN_BODY_BYTES)")).toBeLessThan(
|
|
source.indexOf("safeEqual(submitted, env.MAINTAINER_TOKEN)"),
|
|
);
|
|
});
|
|
|
|
it("keeps paid review callers on the canonical persisted draft namespaces", () => {
|
|
const source = librarySource("./community-agent-tasks.ts");
|
|
expect(source).toContain('hasFreshDraft(env.CURATED_KV, "triage"');
|
|
expect(source).toContain('hasFreshDraft(env.CURATED_KV, "pr-review"');
|
|
expect(source).not.toContain('hasFreshDraft(env.CURATED_KV, "issue"');
|
|
expect(source).not.toContain('hasFreshDraft(env.CURATED_KV, "pr"');
|
|
});
|
|
|
|
it("digest post: never returns ok:true for a no-op (happy path returns real url/number)", () => {
|
|
const source = routeSource("admin/post");
|
|
// The old false-success sentinel must be gone
|
|
expect(source).not.toContain("digest-skipped");
|
|
expect(source).not.toContain("Digest pages are not posted as comments");
|
|
// Happy path must surface the real GitHub Issue outcome
|
|
expect(source).toContain("number: issue.number");
|
|
expect(source).toContain("url: issue.html_url");
|
|
// The draft must be marked posted and stored back on success
|
|
const digestBlock = source.slice(source.indexOf('draft.type === "digest"'));
|
|
expect(digestBlock.indexOf("draft.posted = true")).toBeLessThan(
|
|
digestBlock.indexOf('action: "posted"'),
|
|
);
|
|
});
|
|
|
|
it("digest post: GitHub API failure surfaces a 502 error, not ok:true", () => {
|
|
const source = routeSource("admin/post");
|
|
// On a failed digest GitHub call the handler must return a non-ok error payload
|
|
expect(source).toContain("digestRes.ok");
|
|
// Must propagate the GitHub status rather than swallowing it
|
|
const digestErrorPath = source.slice(
|
|
source.indexOf("digestRes.ok"),
|
|
source.indexOf("digestRes.ok") + 300,
|
|
);
|
|
expect(digestErrorPath).toContain("status: 502");
|
|
expect(digestErrorPath).not.toContain('ok: true');
|
|
});
|
|
});
|