David Benjamin
009f05c242
* Make the build work with -Wformat=2
The -Wformat=2 macro requires every format string either be a string
literal, or a parameter that was tagged with the format attribute. The
upshot is that it expects every printf function to be marked, or you get
warnings like this:
src/console_reporter.cc:104:23: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
104 | out << FormatString(fmt, args);
| ^~~
Marking such things is generally worthwhile since it turns on
error-checking within the library, so fill in the missing ones.
Tested with:
bazelisk build --copt=-Werror --copt=-Wformat=2 :all
* Add -Wformat=2 to catch regressions
104 lines
2.4 KiB
Python
104 lines
2.4 KiB
Python
load("@rules_cc//cc:defs.bzl", "cc_library")
|
|
|
|
licenses(["notice"])
|
|
|
|
COPTS = [
|
|
"-pedantic",
|
|
"-pedantic-errors",
|
|
"-std=c++17",
|
|
"-Wall",
|
|
"-Wconversion",
|
|
"-Wextra",
|
|
"-Wshadow",
|
|
# "-Wshorten-64-to-32",
|
|
"-Wfloat-equal",
|
|
"-Wformat=2",
|
|
"-fstrict-aliasing",
|
|
## assert() are used a lot in tests upstream, which may be optimised out leading to
|
|
## unused-variable warning.
|
|
"-Wno-unused-variable",
|
|
"-Werror=old-style-cast",
|
|
]
|
|
|
|
MSVC_COPTS = [
|
|
"/std:c++17",
|
|
]
|
|
|
|
config_setting(
|
|
name = "windows",
|
|
constraint_values = ["@platforms//os:windows"],
|
|
visibility = [":__subpackages__"],
|
|
)
|
|
|
|
config_setting(
|
|
name = "perfcounters",
|
|
define_values = {
|
|
"pfm": "1",
|
|
},
|
|
visibility = [":__subpackages__"],
|
|
)
|
|
|
|
cc_library(
|
|
name = "benchmark",
|
|
srcs = glob(
|
|
[
|
|
"src/*.cc",
|
|
"src/*.h",
|
|
],
|
|
exclude = ["src/benchmark_main.cc"],
|
|
),
|
|
hdrs = [
|
|
"include/benchmark/benchmark.h",
|
|
"include/benchmark/export.h",
|
|
],
|
|
copts = select({
|
|
":windows": MSVC_COPTS,
|
|
"//conditions:default": COPTS,
|
|
}),
|
|
defines = [
|
|
"BENCHMARK_STATIC_DEFINE",
|
|
"BENCHMARK_VERSION=\\\"" + (module_version() if module_version() != None else "") + "\\\"",
|
|
] + select({
|
|
":perfcounters": ["HAVE_LIBPFM"],
|
|
"//conditions:default": [],
|
|
}),
|
|
includes = ["include"],
|
|
linkopts = select({
|
|
":windows": ["-DEFAULTLIB:shlwapi.lib"],
|
|
"//conditions:default": ["-pthread"],
|
|
}),
|
|
# Only static linking is allowed; no .so will be produced.
|
|
# Using `defines` (i.e. not `local_defines`) means that no
|
|
# dependent rules need to bother about defining the macro.
|
|
linkstatic = True,
|
|
local_defines = [
|
|
# Turn on Large-file Support
|
|
"_FILE_OFFSET_BITS=64",
|
|
"_LARGEFILE64_SOURCE",
|
|
"_LARGEFILE_SOURCE",
|
|
],
|
|
visibility = ["//visibility:public"],
|
|
deps = select({
|
|
":perfcounters": ["@libpfm"],
|
|
"//conditions:default": [],
|
|
}),
|
|
)
|
|
|
|
cc_library(
|
|
name = "benchmark_main",
|
|
srcs = ["src/benchmark_main.cc"],
|
|
hdrs = [
|
|
"include/benchmark/benchmark.h",
|
|
"include/benchmark/export.h",
|
|
],
|
|
includes = ["include"],
|
|
visibility = ["//visibility:public"],
|
|
deps = [":benchmark"],
|
|
)
|
|
|
|
cc_library(
|
|
name = "benchmark_internal_headers",
|
|
hdrs = glob(["src/*.h"]),
|
|
visibility = ["//test:__pkg__"],
|
|
)
|