16cfab7724
* feat(presets): resolve constitutions at command time Gate install-time constitution materialization behind the constitution-sync preset while preserving one-time init seeding and authored-file safeguards. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7dbce70f-80c6-4e14-a30d-78cb358bcb84 * fix(presets): emit composed template content Add a machine-readable preset resolve mode backed by PresetResolver.resolve_content and require the constitution command to consume it. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7dbce70f-80c6-4e14-a30d-78cb358bcb84 * fix(presets): unify runtime template composition Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7dbce70f-80c6-4e14-a30d-78cb358bcb84 * fix(presets): secure runtime template resolution Align runtime resolution across script variants, validate registry path components, and honor canonical extension ordering and convention paths. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * fix(presets): align runtime priority semantics Normalize and tie-break preset priorities consistently across script variants, and preserve template bytes when Python materializes generated files. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * fix(presets): stop at effective template base Avoid parsing irrelevant lower layers once resolution reaches a replace base, and decode raw bytes so Python preserves source line endings. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * fix(presets): align extension template resolution Support root-level extension templates across runtime resolvers, fail safely when Bash cannot parse an extension registry, and validate requested templates in every prerequisite output mode. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * fix(presets): resolve dotted command identifiers Route safe dotted names through command resolution, correct traversal coverage, and make Windows CI text decoding explicit. Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Avoid orphan feature directories on template errors Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Align malformed preset manifest handling Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3158e06f-95df-4e3a-843f-f159a35aa30c * Complete runtime resolver parity Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3158e06f-95df-4e3a-843f-f159a35aa30c * Fail closed on resolver input errors Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3158e06f-95df-4e3a-843f-f159a35aa30c * Force UTF-8 and full manifest validation Force UTF-8 decoding for registry and manifest reads in the Bash and PowerShell embedded-Python parsers so resolution no longer depends on the process locale, and validate every manifest template entry's required fields, type, and strategy consistent with the canonical PresetManifest. Assisted-by: GitHub Copilot (model: claude-opus-4.8, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3158e06f-95df-4e3a-843f-f159a35aa30c * Fail closed on empty manifests and corrupt registries Reject manifests missing the provides/templates sections or declaring an empty template list in all three runtime resolvers, matching the canonical PresetManifest which treats those as invalid instead of silently degrading a composing layer to a convention `replace` lookup. Make a corrupt or unreadable extension registry fail closed in Bash, PowerShell, and Python instead of swallowing the error and treating every on-disk extension directory as unregistered-and-enabled, which could activate a disabled extension. Read the preset and extension registries as explicit UTF-8 in the PowerShell resolver so priority/enabled-state decoding no longer depends on the process code page under Windows PowerShell 5.1. Assisted-by: GitHub Copilot (model: claude-opus-4.8, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3158e06f-95df-4e3a-843f-f159a35aa30c * fix(presets): fail closed when extension registry is not a regular file The Bash and Python resolvers used is_file()/`-f` to gate reading the extension `.registry`, which returns false for a directory or a broken symlink at that path. In those cases the resolvers treated the registry as absent and scanned every on-disk extension directory as unregistered and enabled — a fail-open path. Detect any filesystem entry at the registry path (including broken symlinks) and reject unless it is a readable regular file. PowerShell now rejects a non-leaf entry explicitly for parity. Adds directory- and broken-symlink parity regressions. Assisted-by: GitHub Copilot (model: claude-opus-4.8, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3158e06f-95df-4e3a-843f-f159a35aa30c * fix(presets): fail closed on corrupt registry in canonical resolver and PowerShell Two remaining fail-open paths for an invalid extension registry: - The canonical PresetResolver enumerated extensions through ExtensionRegistry, whose _load() normalizes a corrupt or unreadable registry to an empty mapping. The directory scan then admitted every on-disk extension directory as unregistered-and-enabled, so a corrupt registry could still supply constitution content at init and through constitution-sync materialization. Add a non-invasive is_corrupt() probe (recovery behavior for install/enable/disable is unchanged) and raise from _get_all_extensions_by_priority() when the registry exists but is invalid. _load() now also recovers from OSError/UnicodeDecodeError so a directory or unreadable registry no longer crashes construction. - The PowerShell resolver gated the registry read with Test-Path, which returns false for a dangling symlink on Windows, letting a broken .registry symlink bypass the guard and enable every on-disk extension. Detect the entry via directory enumeration (which observes a broken symlink) and reject it unless it is a readable regular file. Adds canonical corrupt/directory-registry regressions and extends the broken-symlink parity test to PowerShell. Assisted-by: GitHub Copilot (model: claude-opus-4.8, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3158e06f-95df-4e3a-843f-f159a35aa30c * fix(presets): detect dangling registry symlink in ExtensionRegistry.is_corrupt is_corrupt() gated on Path.exists(), which follows symlinks and returns False for a dangling .registry symlink — so the canonical PresetResolver treated it as an absent registry and fell back to scanning every on-disk extension directory as unregistered-and-enabled, reopening the fail-open path this guard closes. Detect lexical existence with os.path.lexists and require a regular file before parsing, so a broken symlink (or directory) is reported corrupt and resolution fails closed. Adds a canonical broken-symlink regression alongside the directory case. Assisted-by: GitHub Copilot (model: claude-opus-4.8, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3158e06f-95df-4e3a-843f-f159a35aa30c --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7dbce70f-80c6-4e14-a30d-78cb358bcb84 Copilot-Session: 3158e06f-95df-4e3a-843f-f159a35aa30c
276 lines
8.5 KiB
Python
276 lines
8.5 KiB
Python
#!/usr/bin/env python3
|
|
"""Consolidated prerequisite checking script."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
import sys
|
|
from dataclasses import dataclass
|
|
from pathlib import Path
|
|
|
|
try:
|
|
from common import (
|
|
FeaturePaths,
|
|
TemplateResolutionError,
|
|
format_speckit_command,
|
|
get_feature_paths,
|
|
resolve_template_content,
|
|
)
|
|
except ImportError: # pragma: no cover - direct execution from unusual cwd
|
|
sys.path.insert(0, str(Path(__file__).resolve().parent))
|
|
from common import (
|
|
FeaturePaths,
|
|
TemplateResolutionError,
|
|
format_speckit_command,
|
|
get_feature_paths,
|
|
resolve_template_content,
|
|
)
|
|
|
|
|
|
def _json_line(payload: object) -> str:
|
|
return json.dumps(payload, ensure_ascii=False, separators=(",", ":")) + "\n"
|
|
|
|
|
|
HELP_TEXT = """Usage: check_prerequisites.py [OPTIONS]
|
|
|
|
Consolidated prerequisite checking for Spec-Driven Development workflow.
|
|
|
|
OPTIONS:
|
|
--json Output in JSON format
|
|
--require-tasks Require tasks.md to exist (for implementation phase)
|
|
--include-tasks Include tasks.md in AVAILABLE_DOCS list
|
|
--paths-only Only output path variables (no prerequisite validation)
|
|
--template NAME Include composed template content in JSON output
|
|
--help, -h Show this help message
|
|
|
|
EXAMPLES:
|
|
# Check task prerequisites (plan.md required)
|
|
./check_prerequisites.py --json
|
|
|
|
# Check implementation prerequisites (plan.md + tasks.md required)
|
|
./check_prerequisites.py --json --require-tasks --include-tasks
|
|
|
|
# Get feature paths only (no validation)
|
|
./check_prerequisites.py --paths-only
|
|
|
|
"""
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class Args:
|
|
json_mode: bool = False
|
|
require_tasks: bool = False
|
|
include_tasks: bool = False
|
|
paths_only: bool = False
|
|
template_name: str | None = None
|
|
|
|
|
|
def _parse_args(argv: list[str]) -> Args:
|
|
json_mode = False
|
|
require_tasks = False
|
|
include_tasks = False
|
|
paths_only = False
|
|
template_name = None
|
|
|
|
index = 0
|
|
while index < len(argv):
|
|
arg = argv[index]
|
|
if arg == "--json":
|
|
json_mode = True
|
|
elif arg == "--require-tasks":
|
|
require_tasks = True
|
|
elif arg == "--include-tasks":
|
|
include_tasks = True
|
|
elif arg == "--paths-only":
|
|
paths_only = True
|
|
elif arg == "--template":
|
|
index += 1
|
|
if index >= len(argv):
|
|
print(
|
|
"ERROR: --template requires a template name",
|
|
file=sys.stderr,
|
|
)
|
|
raise SystemExit(1)
|
|
template_name = argv[index]
|
|
elif arg in {"--help", "-h"}:
|
|
sys.stdout.write(HELP_TEXT)
|
|
raise SystemExit(0)
|
|
else:
|
|
print(
|
|
f"ERROR: Unknown option '{arg}'. Use --help for usage information.",
|
|
file=sys.stderr,
|
|
)
|
|
raise SystemExit(1)
|
|
index += 1
|
|
|
|
return Args(
|
|
json_mode=json_mode,
|
|
require_tasks=require_tasks,
|
|
include_tasks=include_tasks,
|
|
paths_only=paths_only,
|
|
template_name=template_name,
|
|
)
|
|
|
|
|
|
def _dir_has_entries(path: Path) -> bool:
|
|
try:
|
|
return path.is_dir() and any(path.iterdir())
|
|
except OSError:
|
|
return False
|
|
|
|
|
|
def _available_docs(paths: FeaturePaths, include_tasks: bool) -> list[str]:
|
|
docs: list[str] = []
|
|
if paths.research.is_file():
|
|
docs.append("research.md")
|
|
if paths.data_model.is_file():
|
|
docs.append("data-model.md")
|
|
if _dir_has_entries(paths.contracts_dir):
|
|
docs.append("contracts/")
|
|
if paths.quickstart.is_file():
|
|
docs.append("quickstart.md")
|
|
if include_tasks and paths.tasks.is_file():
|
|
docs.append("tasks.md")
|
|
return docs
|
|
|
|
|
|
def _print_paths_only(paths: FeaturePaths, json_mode: bool) -> None:
|
|
if json_mode:
|
|
sys.stdout.write(
|
|
_json_line(
|
|
{
|
|
"REPO_ROOT": str(paths.repo_root),
|
|
"BRANCH": paths.current_branch,
|
|
"FEATURE_DIR": str(paths.feature_dir),
|
|
"FEATURE_SPEC": str(paths.feature_spec),
|
|
"IMPL_PLAN": str(paths.impl_plan),
|
|
"TASKS": str(paths.tasks),
|
|
}
|
|
)
|
|
)
|
|
return
|
|
|
|
print(f"REPO_ROOT: {paths.repo_root}")
|
|
print(f"BRANCH: {paths.current_branch}")
|
|
print(f"FEATURE_DIR: {paths.feature_dir}")
|
|
print(f"FEATURE_SPEC: {paths.feature_spec}")
|
|
print(f"IMPL_PLAN: {paths.impl_plan}")
|
|
print(f"TASKS: {paths.tasks}")
|
|
|
|
|
|
def _status_marker(ok: bool) -> str:
|
|
"""Return the status glyph, downgraded to ASCII when stdout cannot encode it.
|
|
|
|
On Windows sys.stdout falls back to the ANSI code page whenever it is not a
|
|
console - a pipe or a file redirect, which is how agents and workflow steps
|
|
invoke these scripts - and U+2713 is unencodable in cp1252, so printing it
|
|
raised UnicodeEncodeError and aborted the report right after
|
|
"AVAILABLE_DOCS:". "[OK]"/"[FAIL]" is the ASCII rendering these markers
|
|
already have in-tree: see Test-FileExists in scripts/powershell/common.ps1
|
|
and normalize_status_text in tests/parity_helpers.py.
|
|
"""
|
|
glyph = "✓" if ok else "✗"
|
|
try:
|
|
glyph.encode(getattr(sys.stdout, "encoding", None) or "utf-8")
|
|
except (LookupError, UnicodeEncodeError):
|
|
return "[OK]" if ok else "[FAIL]"
|
|
return glyph
|
|
|
|
|
|
def _check_file(path: Path, description: str) -> None:
|
|
print(f" {_status_marker(path.is_file())} {description}")
|
|
|
|
|
|
def _check_dir(path: Path, description: str) -> None:
|
|
print(f" {_status_marker(_dir_has_entries(path))} {description}")
|
|
|
|
|
|
def _print_text_results(paths: FeaturePaths, include_tasks: bool) -> None:
|
|
print(f"FEATURE_DIR:{paths.feature_dir}")
|
|
print("AVAILABLE_DOCS:")
|
|
_check_file(paths.research, "research.md")
|
|
_check_file(paths.data_model, "data-model.md")
|
|
_check_dir(paths.contracts_dir, "contracts/")
|
|
_check_file(paths.quickstart, "quickstart.md")
|
|
if include_tasks:
|
|
_check_file(paths.tasks, "tasks.md")
|
|
|
|
|
|
def main(argv: list[str] | None = None) -> int:
|
|
args = _parse_args(list(argv if argv is not None else sys.argv[1:]))
|
|
|
|
try:
|
|
paths = get_feature_paths(
|
|
no_persist=args.paths_only,
|
|
script_file=Path(__file__),
|
|
)
|
|
except SystemExit as exc:
|
|
if exc.code == 0:
|
|
return 0
|
|
print("ERROR: Failed to resolve feature paths", file=sys.stderr)
|
|
return int(exc.code) if isinstance(exc.code, int) else 1
|
|
|
|
if args.paths_only:
|
|
_print_paths_only(paths, args.json_mode)
|
|
return 0
|
|
|
|
if not paths.feature_dir.is_dir():
|
|
print(f"ERROR: Feature directory not found: {paths.feature_dir}", file=sys.stderr)
|
|
print(
|
|
f"Run {format_speckit_command('specify', paths.repo_root)} first to create the feature structure.",
|
|
file=sys.stderr,
|
|
)
|
|
return 1
|
|
|
|
if not paths.impl_plan.is_file():
|
|
print(f"ERROR: plan.md not found in {paths.feature_dir}", file=sys.stderr)
|
|
print(
|
|
f"Run {format_speckit_command('plan', paths.repo_root)} first to create the implementation plan.",
|
|
file=sys.stderr,
|
|
)
|
|
return 1
|
|
|
|
if args.require_tasks and not paths.tasks.is_file():
|
|
print(f"ERROR: tasks.md not found in {paths.feature_dir}", file=sys.stderr)
|
|
print(
|
|
f"Run {format_speckit_command('tasks', paths.repo_root)} first to create the task list.",
|
|
file=sys.stderr,
|
|
)
|
|
return 1
|
|
|
|
docs = _available_docs(paths, args.include_tasks)
|
|
template_content = None
|
|
if args.template_name:
|
|
try:
|
|
template_content = resolve_template_content(
|
|
args.template_name, paths.repo_root
|
|
)
|
|
except TemplateResolutionError as exc:
|
|
print(f"ERROR: {exc}", file=sys.stderr)
|
|
return 1
|
|
if template_content is None:
|
|
print(
|
|
f"ERROR: Could not resolve required {args.template_name} from "
|
|
f"the template override stack for {paths.repo_root}",
|
|
file=sys.stderr,
|
|
)
|
|
return 1
|
|
|
|
if args.json_mode:
|
|
payload: dict[str, object] = {
|
|
"FEATURE_DIR": str(paths.feature_dir),
|
|
"AVAILABLE_DOCS": docs,
|
|
}
|
|
if args.template_name:
|
|
payload["TEMPLATE_CONTENT"] = template_content
|
|
sys.stdout.write(
|
|
_json_line(payload)
|
|
)
|
|
else:
|
|
_print_text_results(paths, args.include_tasks)
|
|
return 0
|
|
|
|
|
|
if __name__ == "__main__":
|
|
raise SystemExit(main())
|