Manfred Riem
e9ffc9d8e7
* feat: allow overriding default init integration via SPECKIT_INTEGRATION_DEFAULT Resolve the non-interactive/init default integration from the SPECKIT_INTEGRATION_DEFAULT environment variable, fitting the existing SPECKIT_INTEGRATION_* namespace. Falls back to the hardcoded "copilot" default when unset, and warns to stderr (rather than silently falling back) when the value is not a registered integration key. Wires the resolver into specify init (interactive prompt default and non-interactive fallback), the init workflow step, and the bundle init default. Adds unit and CLI tests and documents the variable. Closes #3939 Assisted-by: GitHub Copilot (model: claude-opus-4.8, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: eecda55f-fa13-42f7-99bf-bfb0bb8565a0 * test: cover env-var default wiring for picker, workflow step, and bundle Address PR review: add regression tests so each SPECKIT_INTEGRATION_DEFAULT wiring site cannot silently revert to the hardcoded constant. - init.py: interactive picker receives the resolved key as default_key. - workflow init step: no step/workflow default + env var drives output integration and argv. - bundle _resolve_init_integration: env-var default applies when unspecified, while explicit override and manifest-declared integration still win. Assisted-by: GitHub Copilot (model: claude-opus-4.8, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: eecda55f-fa13-42f7-99bf-bfb0bb8565a0 --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: eecda55f-fa13-42f7-99bf-bfb0bb8565a0
101 lines
3.3 KiB
Python
101 lines
3.3 KiB
Python
"""Tests for the commands/ package structure."""
|
|
import importlib
|
|
|
|
|
|
def test_commands_package_importable():
|
|
mod = importlib.import_module("specify_cli.commands")
|
|
assert mod is not None
|
|
|
|
|
|
def test_commands_init_importable():
|
|
mod = importlib.import_module("specify_cli.commands.init")
|
|
assert hasattr(mod, "register")
|
|
assert callable(mod.register)
|
|
|
|
|
|
def test_agent_config_importable():
|
|
from specify_cli._agent_config import (
|
|
AGENT_CONFIG,
|
|
DEFAULT_INIT_INTEGRATION,
|
|
SCRIPT_TYPE_CHOICES,
|
|
)
|
|
assert isinstance(AGENT_CONFIG, dict)
|
|
assert DEFAULT_INIT_INTEGRATION == "copilot"
|
|
assert "sh" in SCRIPT_TYPE_CHOICES
|
|
|
|
|
|
def test_script_type_choices_includes_python():
|
|
from specify_cli._agent_config import SCRIPT_TYPE_CHOICES
|
|
assert SCRIPT_TYPE_CHOICES.get("py") == "Python"
|
|
# The three supported variants are sh, ps, and py.
|
|
assert {"sh", "ps", "py"} <= set(SCRIPT_TYPE_CHOICES)
|
|
|
|
|
|
def test_workflow_init_valid_script_types_includes_python():
|
|
from specify_cli.workflows.steps.init import VALID_SCRIPT_TYPES
|
|
assert "py" in VALID_SCRIPT_TYPES
|
|
# Negative: an unknown variant is not accepted.
|
|
assert "rb" not in VALID_SCRIPT_TYPES
|
|
|
|
|
|
def test_agent_config_re_exported_from_init():
|
|
from specify_cli import AGENT_CONFIG, SCRIPT_TYPE_CHOICES
|
|
assert isinstance(AGENT_CONFIG, dict)
|
|
assert "sh" in SCRIPT_TYPE_CHOICES
|
|
|
|
|
|
def test_init_command_registered():
|
|
from specify_cli import app
|
|
callback_names = [
|
|
cmd.callback.__name__ for cmd in app.registered_commands if cmd.callback
|
|
]
|
|
assert "init" in callback_names
|
|
|
|
|
|
def test_resolve_default_init_integration_unset(monkeypatch):
|
|
from specify_cli._agent_config import (
|
|
DEFAULT_INIT_INTEGRATION,
|
|
DEFAULT_INIT_INTEGRATION_ENV_VAR,
|
|
resolve_default_init_integration,
|
|
)
|
|
monkeypatch.delenv(DEFAULT_INIT_INTEGRATION_ENV_VAR, raising=False)
|
|
assert resolve_default_init_integration() == DEFAULT_INIT_INTEGRATION
|
|
|
|
|
|
def test_resolve_default_init_integration_valid_override(monkeypatch):
|
|
from specify_cli._agent_config import (
|
|
DEFAULT_INIT_INTEGRATION_ENV_VAR,
|
|
resolve_default_init_integration,
|
|
)
|
|
monkeypatch.setenv(DEFAULT_INIT_INTEGRATION_ENV_VAR, "gemini")
|
|
assert resolve_default_init_integration() == "gemini"
|
|
|
|
|
|
def test_resolve_default_init_integration_whitespace_trimmed(monkeypatch):
|
|
from specify_cli._agent_config import (
|
|
DEFAULT_INIT_INTEGRATION_ENV_VAR,
|
|
resolve_default_init_integration,
|
|
)
|
|
monkeypatch.setenv(DEFAULT_INIT_INTEGRATION_ENV_VAR, " gemini ")
|
|
assert resolve_default_init_integration() == "gemini"
|
|
|
|
|
|
def test_resolve_default_init_integration_invalid_warns_and_falls_back(
|
|
monkeypatch, capsys
|
|
):
|
|
from specify_cli._agent_config import (
|
|
DEFAULT_INIT_INTEGRATION,
|
|
DEFAULT_INIT_INTEGRATION_ENV_VAR,
|
|
resolve_default_init_integration,
|
|
)
|
|
monkeypatch.setenv(DEFAULT_INIT_INTEGRATION_ENV_VAR, "not-a-real-agent")
|
|
assert resolve_default_init_integration() == DEFAULT_INIT_INTEGRATION
|
|
captured = capsys.readouterr()
|
|
assert "not-a-real-agent" in captured.err
|
|
assert DEFAULT_INIT_INTEGRATION_ENV_VAR in captured.err
|
|
|
|
|
|
def test_resolve_default_init_integration_re_exported_from_init():
|
|
from specify_cli import resolve_default_init_integration
|
|
assert callable(resolve_default_init_integration)
|