* errors: improve rate limit error messages for AI agents
When the GitHub API returns a rate limit error, replace the raw Go HTTP
error string with a clean, actionable message so agents know exactly
how long to wait before retrying.
Before:
search code: GET https://api.github.com/search/code: 403 API rate
limit exceeded for user ID 12345. [rate reset in 2m59s]
After:
search code: GitHub API rate limit exceeded. Retry after 2m59s.
create issue: GitHub secondary rate limit exceeded. Retry after 47s.
create issue: GitHub secondary rate limit exceeded. Wait before retrying.
Edge cases: expired/zero reset time, nil RetryAfter, and errors
wrapped with errors.As all produce "Wait before retrying." rather
than a negative or confusing duration.
The original error is stored in context via addGitHubAPIErrorToContext
before the rate-limit check, so middleware is unaffected.
Fixes#2385.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* errors: fix flaky rate limit tests
Compute expectedRetryIn before calling the function under test,
and use larger reset time offsets (20-30 min), so a 1s boundary
during time.Duration.Round cannot cause spurious mismatches.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* errors: extract requireErrorText and assertContextHasError test helpers
Reduces repetition in TestNewGitHubAPIErrorResponse_RateLimits subtests.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Fix edge cases: sub-second rate limit durations and UTF-8 BOM
- Primary rate limit: compute time.Until(resetTime) once and check the
rounded result is >0 before showing 'Retry after X'. This avoids a
TOCTOU race between the After(time.Now()) guard and the subsequent
time.Until call, and prevents showing 'Retry after 0s.' when the
reset time is imminent.
- Secondary rate limit: round RetryAfter first, then check >0.
Previously, a RetryAfter of e.g. 200ms would pass the >0 guard
but format as 'Retry after 0s.' after rounding.
- Add tests for both sub-second edge cases.
- Remove UTF-8 BOM accidentally introduced in error_test.go by
.NET WriteAllText with the default UTF8 encoding.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dan Moseley
1654d32ad8