dd239d8443
* initial logging stack for http * add metrics adapter * fix linter issues * make log fields generic * Update pkg/github/server_test.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Remove unused SlogMetrics adapter The slog-based metrics adapter was never used — OSS always uses NoopMetrics and the remote server has its own DataDog-backed adapter. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Update pkg/github/dependencies.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fmt * change to use slog * address feedback * rename noop adapter to noop sink * Update pkg/http/server.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [WIP] [WIP] Address feedback on OSS logging adapter for http implementation (#2264) * Initial plan * Fix BaseDeps.Logger and BaseDeps.Metrics to return safe defaults when Obsv is nil Agent-Logs-Url: https://github.com/github/github-mcp-server/sessions/53221b0b-abb4-4138-a147-3ce9e13b379a Co-authored-by: mattdholloway <918573+mattdholloway@users.noreply.github.com> * Fix nil metrics in server.go by passing metrics.NewNoopMetrics() to NewExporters Agent-Logs-Url: https://github.com/github/github-mcp-server/sessions/53221b0b-abb4-4138-a147-3ce9e13b379a Co-authored-by: mattdholloway <918573+mattdholloway@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mattdholloway <918573+mattdholloway@users.noreply.github.com> Co-authored-by: Matt Holloway <mattdholloway@github.com> * replace nil with stubs --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
47 lines
1.3 KiB
Go
47 lines
1.3 KiB
Go
package observability
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"log/slog"
|
|
|
|
"github.com/github/github-mcp-server/pkg/observability/metrics"
|
|
)
|
|
|
|
// Exporters bundles observability primitives (logger + metrics) for dependency injection.
|
|
// The logger is Go's stdlib *slog.Logger — integrators provide their own slog.Handler.
|
|
type Exporters interface {
|
|
Logger() *slog.Logger
|
|
Metrics(context.Context) metrics.Metrics
|
|
}
|
|
|
|
type exporters struct {
|
|
logger *slog.Logger
|
|
metrics metrics.Metrics
|
|
}
|
|
|
|
// NewExporters creates an Exporters bundle. Pass a configured *slog.Logger
|
|
// (with whatever slog.Handler you need) and a Metrics implementation.
|
|
// Neither may be nil; use slog.New(slog.DiscardHandler) and metrics.NewNoopMetrics()
|
|
// if logging or metrics are unwanted.
|
|
func NewExporters(logger *slog.Logger, m metrics.Metrics) (Exporters, error) {
|
|
if logger == nil {
|
|
return nil, errors.New("logger must not be nil: use slog.New(slog.DiscardHandler) to discard logs")
|
|
}
|
|
if m == nil {
|
|
return nil, errors.New("metrics must not be nil: use metrics.NewNoopMetrics() to discard metrics")
|
|
}
|
|
return &exporters{
|
|
logger: logger,
|
|
metrics: m,
|
|
}, nil
|
|
}
|
|
|
|
func (e *exporters) Logger() *slog.Logger {
|
|
return e.logger
|
|
}
|
|
|
|
func (e *exporters) Metrics(_ context.Context) metrics.Metrics {
|
|
return e.metrics
|
|
}
|