Martin Vogel
0d46fffbaa
The macOS Intel leg failed the fixture contract on every run while every other platform passed. Removing the readiness fsync did not change it; the hardened diagnostics named the real cause on the first remote run: waited=30.0s, exit_status=alive, port_file=absent, staged_temp_files=none, empty startup log -- the process was healthy but had never reached publish_port. http.server.HTTPServer.server_bind() resolves socket.getfqdn(host). On a host whose resolver does not answer for the bind address that call blocks for the resolver timeout, so the constructor never returns and no port is ever published. The fixture now binds through a subclass that keeps the threading server but skips the FQDN resolution, which only feeds CGI-style variables this fixture never serves. Proven both directions locally by forcing socket.getfqdn to hang: the subclass publishes its port immediately, the stock server never does. That forcing hook is kept as a permanent contract guard, so the reverse-DNS dependency cannot return without turning the gate red on every platform rather than on one runner nobody can reproduce. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
81 lines
2.6 KiB
Python
Executable File
81 lines
2.6 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
"""Serve smoke-test release artifacts from a race-free ephemeral port."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import argparse
|
|
import functools
|
|
import http.server
|
|
import os
|
|
import pathlib
|
|
import socketserver
|
|
import tempfile
|
|
|
|
|
|
class FixtureHTTPServer(http.server.ThreadingHTTPServer):
|
|
"""Bind without the stdlib's reverse-DNS lookup.
|
|
|
|
http.server.HTTPServer.server_bind() resolves socket.getfqdn(host). On a
|
|
host whose resolver does not answer for the bind address that call blocks
|
|
for the resolver timeout, so the process stays alive and never reaches
|
|
publish_port -- observed on macOS Intel runners as waited=30.0s,
|
|
exit_status=alive, port_file=absent, empty startup log. The FQDN only
|
|
feeds CGI-style variables this fixture never serves, so binding without
|
|
it is both sufficient and immune to resolver behaviour.
|
|
"""
|
|
|
|
def server_bind(self) -> None:
|
|
socketserver.TCPServer.server_bind(self)
|
|
host, port = self.server_address[:2]
|
|
self.server_name = host
|
|
self.server_port = port
|
|
|
|
|
|
def publish_port(port_file: pathlib.Path, port: int) -> None:
|
|
"""Atomically publish the assigned port after the listening socket exists."""
|
|
port_file.parent.mkdir(parents=True, exist_ok=True)
|
|
with tempfile.NamedTemporaryFile(
|
|
mode="w",
|
|
encoding="ascii",
|
|
dir=port_file.parent,
|
|
prefix=f".{port_file.name}.",
|
|
delete=False,
|
|
) as temporary:
|
|
temporary.write(f"{port}\n")
|
|
temporary.flush()
|
|
temporary_path = pathlib.Path(temporary.name)
|
|
try:
|
|
os.replace(temporary_path, port_file)
|
|
except BaseException:
|
|
temporary_path.unlink(missing_ok=True)
|
|
raise
|
|
|
|
|
|
def main() -> None:
|
|
parser = argparse.ArgumentParser()
|
|
parser.add_argument("--directory", required=True, type=pathlib.Path)
|
|
parser.add_argument("--port-file", required=True, type=pathlib.Path)
|
|
parser.add_argument("--bind", default="127.0.0.1")
|
|
args = parser.parse_args()
|
|
|
|
directory = args.directory.resolve(strict=True)
|
|
if not directory.is_dir():
|
|
parser.error(f"--directory is not a directory: {directory}")
|
|
|
|
handler = functools.partial(
|
|
http.server.SimpleHTTPRequestHandler,
|
|
directory=str(directory),
|
|
)
|
|
with FixtureHTTPServer((args.bind, 0), handler) as server:
|
|
publish_port(args.port_file, server.server_port)
|
|
print(
|
|
f"smoke fixture server: http://{args.bind}:{server.server_port} "
|
|
f"from {directory}",
|
|
flush=True,
|
|
)
|
|
server.serve_forever()
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|