github-featured / comet-ml--opik

发布

0 发布 8,340 Git 标签

RSS 订阅源
  • 2.0.30-5303 80c0a42b8a
    比较

    [OPIK-6434] [BE][FE] chore: remove TOGGLE_RUNNERS_ENABLED toggle (#6663)

    frostbyte_neo 发布于 2026-05-11 14:11:56 +00:00

    Hardcode the local-runner subsystem as always-on. TOGGLE_RUNNERS_ENABLED
    gated the LocalRunnerReaperJob and the Pairing / LocalRunners API
    endpoints. It was set to true only in cloud SaaS prod (comet-helm
    values-production-opik.yaml) and false-or-unset everywhere else
    (dev/stg/test/prod-test/self-hosted-eks/opik-on-opik, STSaaS deployments
    running Opik, pr-* adhoc, OSS docker-compose). The frontend declaration
    had zero tsx consumers.

    After this change the reaper job and Pairing / LocalRunners endpoints
    are active in every environment. Cloud SaaS prod behavior is unchanged.

    • Backend: drop the enabled field from LocalRunnerConfig; remove the
      isEnabled() gate from OpikGuiceyLifecycleEventListener,
      LocalRunnerReaperJob, PairingResource (incl. its 501 ApiResponse
      annotations and unused imports), and LocalRunnersResource (18
      callsites + helper).
    • Config: drop localRunner.enabled / TOGGLE_RUNNERS_ENABLED from
      apps/opik-backend/config.yml, config-test.yml, and
      deployment/docker-compose/docker-compose.yaml.
    • Frontend: remove TOGGLE_RUNNERS_ENABLED enum value and default state.
    • Tests: delete PairingResourceFeatureFlagDisabledTest (premise gone);
      drop isEnabled / setEnabled stubs and the skipsWhenDisabled case from
      LocalRunnerReaperJobTest, LocalRunnerReaperIntegrationTest, and
      LocalRunnerServiceImplTest.

    Follow-up (separate repos): remove the now-ignored
    TOGGLE_RUNNERS_ENABLED override in comet-helm/values-production-opik.yaml
    and the chart default in comet-ml-helm-chart/values.yaml.

    Co-authored-by: Claude Opus 4.7 (1M context) noreply@anthropic.com

    下载附件