-
[OPIK-6360] [INFRA] fix: emit labels for every dropdown entry in regenerated YAML and fix path in job (#6588)
发布于
2026-05-04 09:27:27 +00:00 - [OPIK-6360] [INFRA] fix: emit labels for every dropdown entry in regenerated YAML
The skip-emit-when-label-equals-id optimization in regenerate_llm_models_yaml
made every OpenRouter model invisible in the FE dropdown once the CDN-served
YAML became the runtime source of truth. OpenRouter's FE labels are
identical to its ids by convention, so the optimization stripped all
~800 OpenRouter labels — and the FE filter uses label-presence as the
"is this dropdown-visible?" signal, dropping the entire list.Removing the
entry.label != model_idcheck restores labels for every
dropdown-visible entry. Adds ~30KB to the cold-cached YAML, which is
trivial compared to the correctness fragility of the omit-when-equal
rule (and the byte cost was the only argument for it).The YAML itself is intentionally not regenerated in this commit — the
daily sync workflow (sync_provider_models.yml) will pick up this script
change on its next run and produce a normal sync PR with the
regenerated llm-models-default.yaml.OPIK-6360
- [OPIK-6360] [INFRA] fix: stage provider models from new constants/ location in sync workflow
The Sync Provider Models Daily workflow's
git addlist still referenced
the pre-OPIK-5021 location of PROVIDER_MODELS
(apps/opik-frontend/src/hooks/useLLMProviderModelsData.ts), but that
constant moved to apps/opik-frontend/src/constants/providerModels.ts.Symptoms:
- Sync runs that produced real changes to the constant left the new file
unstaged. The peter-evans/create-pull-request action's "Uncommitted
changes found. Adding a commit." fallback caught it on the action side
and made a second commit, but this split one logical change across two
commits in the resulting PR and would have lost the change entirely
if anyone disabled that fallback. - Visible in PR #6576 which ended with 0 changed files: the staged set
was already redundant against main, and the unstaged providerModels.ts
changes were the only meaningful diff that could have prevented that.
One-line path swap.
下载附件