-
[OPIK-3025] [FE] Add 'Comments' to 'Feedback options' table for empty state (#4031)
frostbyte_neo 发布于
2025-11-11 15:11:04 +00:00 -
[OPIK-3025] [FE] Add 'Comments' to 'Feedback options' table for empty state
-
Revision 2: Improve Comments row description text
-
Revision 3: Hide 'Available values' column when only Comments row is displayed
-
Revision 4: Remove color indicator from Comments row
-
Revision 5: Revert custom cell renderer for Comments row
-
Revision 6: Refactor duplicate checks and create dedicated FeedbackScoreCommentsCell
- Extract repeated checks into well-named variables (hasComments, hasFeedbackDefinitions, hasOnlyComments)
- Create dedicated FeedbackScoreCommentsCell component for Comments row rendering
- Use dedicated cell component when only Comments row is displayed
- Improves code readability and maintainability
Addresses review feedback from @andriidudar
- Revision 7: Refactor cell component architecture with FeedbackOptionCell router
- Rename FeedbackScoreCommentsCell to FeedbackOptionCommentCell
- Create FeedbackOptionCell as routing component that decides between FeedbackOptionCommentCell and FeedbackScoreNameCell based on value
- Use FeedbackOptionCell in DEFAULT_COLUMNS for cleaner architecture
- Simplify columns useMemo by removing conditional column configurations
- Cell routing logic now encapsulated in FeedbackOptionCell component
Improves code organization and maintainability
- Revision 8: Move FeedbackOption cells to annotation-queues directory and improve styling
- Move FeedbackOptionCell.tsx and FeedbackOptionCommentCell.tsx to pages-shared/annotation-queues/
- Update imports to use relative paths for co-located components
- Apply text styling to Comments cell (comet-body-s-accented text-muted-slate)
- Better organization: cells specific to annotation queues now located with ScoresContent
Improves code organization and visual consistency
下载附件
-