[OPIK-2441] [BE] Fix feedback score deletion not working when author is provided (#3338)
frostbyte_neo
发布于
2025-09-21 12:21:48 +00:00
- [OPIK-2441] [BE] Fix feedback score deletion not working when author is provided
- Fix deleteScoreFrom() method to consider writeToAuthored configuration when author is provided
- Fix deleteByEntityIdAndNames() method with same logic for batch operations
- Add FeedbackScoresConfig dependency injection to FeedbackScoreDAO
- Add comprehensive tests to verify fix works for both single and batch delete operations
- Ensure deletion works when writeToAuthored=false regardless of author presence
- Move feedback score deletion tests to appropriate test files
- Moved tests from FeedbackScoreDeletionWithAuthorTest.java to TracesResourceTest.java and SpansResourceTest.java
- Added tests for both traces and spans feedback score deletion with/without author when writeToAuthored=false
- Removed the original standalone test file to maintain better test organization
- Move feedback score deletion tests to existing nested classes
- Moved tests from standalone nested class to existing DeleteTraceFeedback class in TracesResourceTest.java
- Moved tests from standalone nested class to existing DeleteSpanFeedbackDefinition class in SpansResourceTest.java
- Tests now follow proper organization within existing test structure
- Both trace and span tests verify feedback score deletion behavior when writeToAuthored=false
下载附件