github-featured/apple--container
2
0
Fork 0
Code Issues Pull Requests Deployments Models Agent Notes Packages Projects Releases Wiki Activity

Pass build config in when building protoc dependencies (#1972)

Browse Source 
- The protobuf makefile relies on being able to find
  the built protoc dependencies under the build
  directory. Since we were not passing the build
  configuration to the swift command to build those
  dependencies, the built binaries were going into
  the debug build folder. If make protos was run
  when `BUILD_CONFIGURATION=release`, then
  we'd fail to find the dependencies since the build
  folder should now be the release build folder.
  This PR fixes that.

Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
This commit is contained in:
Kathryn Baldauf
2026-07-21 17:48:11 -07:00
committed by GitHub
parent 0c0d3c6ff1
commit f4757afa43
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Protobuf.Makefile
+2 -2
View File
@@ -36,8 +36,8 @@ $(PROTOC):
.PHONY: protoc-gen-swift .PHONY: protoc-gen-swift
protoc-gen-swift: protoc-gen-swift:
@$(SWIFT) build --product protoc-gen-swift @$(SWIFT) build -c $(BUILD_CONFIGURATION) --product protoc-gen-swift
@$(SWIFT) build --product protoc-gen-grpc-swift-2 @$(SWIFT) build -c $(BUILD_CONFIGURATION) --product protoc-gen-grpc-swift-2
.PHONY: protos .PHONY: protos
protos: $(PROTOC) protoc-gen-swift protos: $(PROTOC) protoc-gen-swift