From 36d96d62b73e217ce2c002645962c58c17a5a2af Mon Sep 17 00:00:00 2001
From: shuai <lishuailing@sifou.com>
Date: Fri, 6 Jan 2023 18:44:04 +0800
Subject: [PATCH 1/8] fix: lables nesting error

---
 .../Detail/components/ContentLoader/index.tsx | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/ui/src/pages/Questions/Detail/components/ContentLoader/index.tsx b/ui/src/pages/Questions/Detail/components/ContentLoader/index.tsx
index 7999e532..b3cd31a4 100644
--- a/ui/src/pages/Questions/Detail/components/ContentLoader/index.tsx
+++ b/ui/src/pages/Questions/Detail/components/ContentLoader/index.tsx
@@ -14,47 +14,47 @@ const Index: FC = () => {
 
       <div style={{ marginBottom: '2rem' }}>
         <p>
-          <div
+          <span
             className="placeholder w-100 d-block align-top mb-1"
             style={{ height: '24px' }}
           />
-          <div
+          <span
             className="placeholder w-100 d-block align-top mb-1"
             style={{ height: '24px' }}
           />
-          <div
+          <span
             className="placeholder w-100 d-block align-top mb-1"
             style={{ height: '24px' }}
           />
 
-          <div
+          <span
             className="placeholder w-100 d-block align-top mb-1"
             style={{ height: '24px' }}
           />
-          <div
+          <span
             className="placeholder w-75 d-block align-top"
             style={{ height: '24px' }}
           />
         </p>
 
         <p>
-          <div
+          <span
             className="placeholder w-100 d-block align-top mb-1"
             style={{ height: '24px' }}
           />
-          <div
+          <span
             className="placeholder w-100 d-block align-top mb-1"
             style={{ height: '24px' }}
           />
-          <div
+          <span
             className="placeholder w-100 d-block align-top mb-1"
             style={{ height: '24px' }}
           />
-          <div
+          <span
             className="placeholder w-100 d-block align-top mb-1"
             style={{ height: '24px' }}
           />
-          <div
+          <span
             className="placeholder w-50 d-block align-top"
             style={{ height: '24px' }}
           />

From e670a6fbece5be5600a087cce9353f96c236196d Mon Sep 17 00:00:00 2001
From: "haitao(lj)" <haitao@sifou.com>
Date: Fri, 6 Jan 2023 18:44:29 +0800
Subject: [PATCH 2/8] fix(Comment): Block data submission when comment value is
 empty

---
 ui/src/components/Comment/index.tsx | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/ui/src/components/Comment/index.tsx b/ui/src/components/Comment/index.tsx
index 1c3191aa..24abb22e 100644
--- a/ui/src/components/Comment/index.tsx
+++ b/ui/src/components/Comment/index.tsx
@@ -100,6 +100,9 @@ const Comment = ({ objectId, mode, commentId }) => {
     const users = matchedUsers(item.value);
     const userNames = unionBy(users.map((user) => user.userName));
     const html = marked.parse(parseUserInfo(item.value));
+    if (!item.value || !html) {
+      return;
+    }
     const params = {
       object_id: objectId,
       original_text: item.value,

From 5758868106d753b080e68bb61effa00ae08390a0 Mon Sep 17 00:00:00 2001
From: "haitao(lj)" <haitao@sifou.com>
Date: Mon, 9 Jan 2023 14:42:49 +0800
Subject: [PATCH 3/8] fix(settings/seo): set `font-monospace` className for
 robots field

---
 ui/src/pages/Admin/Seo/index.tsx | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ui/src/pages/Admin/Seo/index.tsx b/ui/src/pages/Admin/Seo/index.tsx
index 32744dc7..66625e8b 100644
--- a/ui/src/pages/Admin/Seo/index.tsx
+++ b/ui/src/pages/Admin/Seo/index.tsx
@@ -38,6 +38,7 @@ const Index: FC = () => {
       'ui:widget': 'textarea',
       'ui:options': {
         rows: 10,
+        className: 'font-monospace',
       },
     },
   };

From c0cf0e6861eb443633036d53a28ca2b0cedc0a28 Mon Sep 17 00:00:00 2001
From: "haitao(lj)" <haitao@sifou.com>
Date: Mon, 9 Jan 2023 15:21:25 +0800
Subject: [PATCH 4/8] fix(siteName): Use dynamic site names on registration and
 login pages

---
 i18n/en_US.yaml                       |  2 +-
 ui/src/components/Footer/index.tsx    |  4 +---
 ui/src/components/Header/index.tsx    |  3 +--
 ui/src/pages/Users/Login/index.tsx    | 14 ++++++++++----
 ui/src/pages/Users/Register/index.tsx |  7 +++++--
 ui/src/stores/siteInfo.ts             |  6 +++++-
 6 files changed, 23 insertions(+), 13 deletions(-)

diff --git a/i18n/en_US.yaml b/i18n/en_US.yaml
index 476bc2a2..35d0f40f 100644
--- a/i18n/en_US.yaml
+++ b/i18n/en_US.yaml
@@ -607,7 +607,7 @@ ui:
     msg:
       empty: Cannot be empty.
   login:
-    page_title: Welcome to Answer
+    page_title: Welcome to {{site_name}}
     info_sign: Don't have an account? <1>Sign up</1>
     info_login: Already have an account? <1>Log in</1>
     agreements: By registering, you agree to the <1>privacy policy</1> and <3>terms of service</3>.
diff --git a/ui/src/components/Footer/index.tsx b/ui/src/components/Footer/index.tsx
index eb31feec..578576ce 100644
--- a/ui/src/components/Footer/index.tsx
+++ b/ui/src/components/Footer/index.tsx
@@ -5,12 +5,10 @@ import { Trans } from 'react-i18next';
 import dayjs from 'dayjs';
 
 import { siteInfoStore } from '@/stores';
-import { DEFAULT_SITE_NAME } from '@/common/constants';
 
 const Index = () => {
   const fullYear = dayjs().format('YYYY');
-  const siteName =
-    siteInfoStore((state) => state.siteInfo.name) || DEFAULT_SITE_NAME;
+  const siteName = siteInfoStore((state) => state.siteInfo.name);
   const cc = `${fullYear} ${siteName}`;
   return (
     <footer className="bg-light py-3">
diff --git a/ui/src/components/Header/index.tsx b/ui/src/components/Header/index.tsx
index f98e3f4f..d18f9ae6 100644
--- a/ui/src/components/Header/index.tsx
+++ b/ui/src/components/Header/index.tsx
@@ -28,7 +28,6 @@ import {
   themeSettingStore,
 } from '@/stores';
 import { logout, useQueryNotificationStatus } from '@/services';
-import { DEFAULT_SITE_NAME } from '@/common/constants';
 
 import NavItems from './components/NavItems';
 
@@ -121,7 +120,7 @@ const Header: FC = () => {
                 />
               </>
             ) : (
-              <span>{siteInfo.name || DEFAULT_SITE_NAME}</span>
+              <span>{siteInfo.name}</span>
             )}
           </Navbar.Brand>
 
diff --git a/ui/src/pages/Users/Login/index.tsx b/ui/src/pages/Users/Login/index.tsx
index ff8aec57..2172b75b 100644
--- a/ui/src/pages/Users/Login/index.tsx
+++ b/ui/src/pages/Users/Login/index.tsx
@@ -12,7 +12,11 @@ import type {
   FormDataType,
 } from '@/common/interface';
 import { Unactivate } from '@/components';
-import { loggedUserInfoStore, loginSettingStore } from '@/stores';
+import {
+  loggedUserInfoStore,
+  loginSettingStore,
+  siteInfoStore,
+} from '@/stores';
 import { guard, floppyNavigation, handleFormError } from '@/utils';
 import { login, checkImgCode } from '@/services';
 import { PicAuthCodeModal } from '@/components/Modal';
@@ -23,8 +27,8 @@ const Index: React.FC = () => {
   const navigate = useNavigate();
   const [searchParams] = useSearchParams();
   const [refresh, setRefresh] = useState(0);
-  const updateUser = loggedUserInfoStore((state) => state.update);
-  const storeUser = loggedUserInfoStore((state) => state.user);
+  const { name: siteName } = siteInfoStore((_) => _.siteInfo);
+  const { user: storeUser, update: updateUser } = loggedUserInfoStore((_) => _);
   const loginSetting = loginSettingStore((state) => state.login);
   const [formData, setFormData] = useState<FormDataType>({
     e_mail: {
@@ -170,7 +174,9 @@ const Index: React.FC = () => {
   });
   return (
     <Container style={{ paddingTop: '4rem', paddingBottom: '5rem' }}>
-      <h3 className="text-center mb-5">{t('page_title')}</h3>
+      <h3 className="text-center mb-5">
+        {t('page_title', { site_name: siteName })}
+      </h3>
       {step === 1 && (
         <Col className="mx-auto" md={3}>
           <Form noValidate onSubmit={handleSubmit}>
diff --git a/ui/src/pages/Users/Register/index.tsx b/ui/src/pages/Users/Register/index.tsx
index 2fb0d03c..fbf8b861 100644
--- a/ui/src/pages/Users/Register/index.tsx
+++ b/ui/src/pages/Users/Register/index.tsx
@@ -4,13 +4,14 @@ import { useTranslation } from 'react-i18next';
 
 import { usePageTags } from '@/hooks';
 import { Unactivate } from '@/components';
+import { siteInfoStore } from '@/stores';
 
 import SignUpForm from './components/SignUpForm';
 
 const Index: React.FC = () => {
   const [showForm, setShowForm] = useState(true);
   const { t } = useTranslation('translation', { keyPrefix: 'login' });
-
+  const { name: siteName } = siteInfoStore((_) => _.siteInfo);
   const onStep = () => {
     setShowForm((bol) => !bol);
   };
@@ -19,7 +20,9 @@ const Index: React.FC = () => {
   });
   return (
     <Container style={{ paddingTop: '4rem', paddingBottom: '5rem' }}>
-      <h3 className="text-center mb-5">{t('page_title')}</h3>
+      <h3 className="text-center mb-5">
+        {t('page_title', { site_name: siteName })}
+      </h3>
       {showForm ? (
         <SignUpForm callback={onStep} />
       ) : (
diff --git a/ui/src/stores/siteInfo.ts b/ui/src/stores/siteInfo.ts
index 978c10b4..e484f554 100644
--- a/ui/src/stores/siteInfo.ts
+++ b/ui/src/stores/siteInfo.ts
@@ -1,6 +1,7 @@
 import create from 'zustand';
 
 import { AdminSettingsGeneral } from '@/common/interface';
+import { DEFAULT_SITE_NAME } from '@/common/constants';
 
 interface SiteInfoType {
   siteInfo: AdminSettingsGeneral;
@@ -9,7 +10,7 @@ interface SiteInfoType {
 
 const siteInfo = create<SiteInfoType>((set) => ({
   siteInfo: {
-    name: '',
+    name: DEFAULT_SITE_NAME,
     description: '',
     short_description: '',
     site_url: '',
@@ -19,6 +20,9 @@ const siteInfo = create<SiteInfoType>((set) => ({
   update: (params) =>
     set((_) => {
       const o = { ..._.siteInfo, ...params };
+      if (!o.name) {
+        o.name = DEFAULT_SITE_NAME;
+      }
       return {
         siteInfo: o,
       };

From 8acd8d65432130fe058fea900952096218e2388c Mon Sep 17 00:00:00 2001
From: robin <robin@rnode.me>
Date: Mon, 9 Jan 2023 17:02:07 +0800
Subject: [PATCH 5/8] fix: solve the problem that comments cannot be deleted

---
 ui/src/components/Comment/index.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/src/components/Comment/index.tsx b/ui/src/components/Comment/index.tsx
index 24abb22e..1b4f0178 100644
--- a/ui/src/components/Comment/index.tsx
+++ b/ui/src/components/Comment/index.tsx
@@ -27,7 +27,6 @@ import './index.scss';
 const Comment = ({ objectId, mode, commentId }) => {
   const pageUsers = usePageUsers();
   const [pageIndex, setPageIndex] = useState(0);
-  const [comments, setComments] = useState<any>([]);
   const [visibleComment, setVisibleComment] = useState(false);
   const pageSize = pageIndex === 0 ? 3 : 15;
   const { data, mutate } = useQueryComments({
@@ -36,6 +35,7 @@ const Comment = ({ objectId, mode, commentId }) => {
     page: pageIndex,
     page_size: pageSize,
   });
+  const [comments, setComments] = useState<any>(data?.list || []);
 
   const reportModal = useReportModal();
 

From 2b581522f2407720574ad871e42daf0d890abcf4 Mon Sep 17 00:00:00 2001
From: "haitao(lj)" <haitao@sifou.com>
Date: Mon, 9 Jan 2023 17:07:42 +0800
Subject: [PATCH 6/8] fix(Question): Sanitize the HTML for question content

---
 ui/src/components/Editor/Viewer.tsx | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ui/src/components/Editor/Viewer.tsx b/ui/src/components/Editor/Viewer.tsx
index c5bc69f8..fa5cb3ba 100644
--- a/ui/src/components/Editor/Viewer.tsx
+++ b/ui/src/components/Editor/Viewer.tsx
@@ -14,6 +14,7 @@ import { htmlRender } from './utils';
 let scrollTop = 0;
 marked.setOptions({
   breaks: true,
+  sanitize: true,
 });
 
 const Index = ({ value }, ref) => {

From 4a40f77c56ce6a0ded63f175de586a47ce503985 Mon Sep 17 00:00:00 2001
From: robin <robin@rnode.me>
Date: Mon, 9 Jan 2023 17:35:59 +0800
Subject: [PATCH 7/8] fix: solve the problem that comments cannot be deleted

---
 ui/src/components/Comment/index.tsx | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/ui/src/components/Comment/index.tsx b/ui/src/components/Comment/index.tsx
index 1b4f0178..8bf98aae 100644
--- a/ui/src/components/Comment/index.tsx
+++ b/ui/src/components/Comment/index.tsx
@@ -35,7 +35,7 @@ const Comment = ({ objectId, mode, commentId }) => {
     page: pageIndex,
     page_size: pageSize,
   });
-  const [comments, setComments] = useState<any>(data?.list || []);
+  const [comments, setComments] = useState<any>([]);
 
   const reportModal = useReportModal();
 
@@ -167,9 +167,8 @@ const Comment = ({ objectId, mode, commentId }) => {
         deleteComment(id).then(() => {
           if (pageIndex === 0) {
             mutate();
-          } else {
-            setComments(comments.filter((item) => item.comment_id !== id));
           }
+          setComments(comments.filter((item) => item.comment_id !== id));
         });
       },
     });

From a4f69d24d56dbac267d7ccc693ef7640a9ea64ae Mon Sep 17 00:00:00 2001
From: "haitao(lj)" <haitao@sifou.com>
Date: Mon, 9 Jan 2023 17:43:05 +0800
Subject: [PATCH 8/8] fix(scroll): Set scroll position for Question detail

---
 ui/src/components/Operate/index.tsx     | 6 +++---
 ui/src/pages/Questions/Detail/index.tsx | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/ui/src/components/Operate/index.tsx b/ui/src/components/Operate/index.tsx
index 1dfa3f46..a711d8ed 100644
--- a/ui/src/components/Operate/index.tsx
+++ b/ui/src/components/Operate/index.tsx
@@ -41,10 +41,10 @@ const Index: FC<IProps> = ({
   const navigate = useNavigate();
   const reportModal = useReportModal();
 
-  const refershQuestion = () => {
+  const refreshQuestion = () => {
     callback?.('default');
   };
-  const closeModal = useReportModal(refershQuestion);
+  const closeModal = useReportModal(refreshQuestion);
   const editUrl =
     type === 'answer' ? `/posts/${qid}/${aid}/edit` : `/posts/${qid}/edit`;
 
@@ -132,7 +132,7 @@ const Index: FC<IProps> = ({
             msg: t('success', { keyPrefix: 'question_detail.reopen' }),
             variant: 'success',
           });
-          refershQuestion();
+          refreshQuestion();
         });
       },
     });
diff --git a/ui/src/pages/Questions/Detail/index.tsx b/ui/src/pages/Questions/Detail/index.tsx
index 2b9a121f..436b1dd3 100644
--- a/ui/src/pages/Questions/Detail/index.tsx
+++ b/ui/src/pages/Questions/Detail/index.tsx
@@ -123,7 +123,6 @@ const Index = () => {
       }, 1000);
       return;
     }
-
     if (type === 'default') {
       window.scrollTo(0, 0);
       getDetail();
@@ -150,6 +149,7 @@ const Index = () => {
     if (!qid) {
       return;
     }
+    window.scrollTo(0, 0);
     getDetail();
     requestAnswers();
   }, [qid]);